Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remove] LegacyESVersion.V_7_8_* and V_7_9_* constants #4855

Merged
merged 5 commits into from
Nov 1, 2022
Merged

[Remove] LegacyESVersion.V_7_8_* and V_7_9_* constants #4855

merged 5 commits into from
Nov 1, 2022

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Oct 20, 2022

Removes all usages of LegacyESVersion.V_7_8_ and LegacyESVersion.V_7_9 version constants along with ancient API logic.

relates #2747

@nknize nknize added non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues >upgrade Label used when upgrading library dependencies (e.g., Lucene) v3.0.0 Issues and PRs related to version 3.0.0 labels Oct 20, 2022
@nknize nknize requested review from a team and reta as code owners October 20, 2022 18:32
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@nknize nknize requested a review from dblock October 21, 2022 16:59
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

dblock
dblock requested changes Oct 24, 2022
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one more, see below?

server/src/main/java/org/opensearch/cluster/action/index/MappingUpdatedAction.java Outdated Show resolved Hide resolved
@nknize
[Remove] LegacyESVersion.V_7_8_* and V_7_9_* constants
53ed55f 
Removes all usages of LegacyESVersion.V_7_8_ and LegacyESVersion.V_7_9
version constants along with ancient API logic.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize
update changelog
ae2f748 
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize
revert masterNodeTimeout method call
21f93e3 
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize
cleanup MappingUpdatedAction to remove unexecuted code
6462c72 
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize force-pushed the remove/7879VersionConstants branch from ba4b5b0 to 6462c72 Compare October 31, 2022 17:52
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@nknize
revert timeout deletion
476a5a5 
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@nknize nknize requested a review from dblock October 31, 2022 19:23
@dblock dblock merged commit db418fb into opensearch-project:main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

Assignees
No one assigned
Labels
non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues >upgrade Label used when upgrading library dependencies (e.g., Lucene) v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nknize @dblock