Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix boundary condition in indexing pressure test #5168

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Fix boundary condition in indexing pressure test #5168

merged 1 commit into from
Nov 9, 2022

Commits on Nov 9, 2022

  1. Fix boundary condition in indexing pressure test 

    This updates the boundary condition in an assertion in two tests in
ShardIndexingPressureConcurrentExecutionTests. I could reliably
reproduce errors here by running:

```
./gradlew ':server:test' -Dtests.iters=10000 --tests "org.opensearch.index.ShardIndexingPressureConcurrentExecutionTests.testReplicaThreadedUpdateToShardLimits"
```

On every error the value that failed was exactly 0.95 and failed the
less than check. The change here is to accept 0.95, and also refactor
the test to give a better error message on failure.

Signed-off-by: Andrew Ross <andrross@amazon.com>
    @andrross
    andrross committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    179c1e7 View commit details
    Browse the repository at this point in the history