Fix for InternalDistributionArchiveCheckPluginFuncTest failure on win… #5401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dows Signed-off-by: Poojita Raj <poojiraj@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
mch2
approved these changes
Nov 29, 2022
owaiskazi19
changed the title
owaiskazi19
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dows
Signed-off-by: Poojita Raj poojiraj@amazon.com
Description
Resolves the failure for InternalDistributionArchiveCheckPluginFuncTest on windows. This is because the build of darwin tar gets skipped on windows so instead of the failure condition we check for on other machines, we should be checking if it gets skipped on windows.
To reproduce failure - on windows machine, run -
./gradlew :build-tools:integTest --tests "org.opensearch.gradle.internal.InternalDistributionArchiveCheckPluginFuncTest"Issues Resolved
Resolves #5324
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.