Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TransportActions support and removed LocalNodeResponse for extensions #5615

Merged

Conversation

ryanbogan
Copy link
Member

@ryanbogan ryanbogan commented Dec 22, 2022

Description

This PR merges the fourth batch of feature/extensions into main and will then be backported to 2.x. It adds TransportActions support and removes LocalNodeResponse for extensions

Note: This PR must be merged after #5597 as it contains all of the changes from that PR.

Issues Resolved

Issue with links to PR's included in this merge: #5273
Meta issue for entire feature/extensions merge: #5263

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…createComponents support for extensions

Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
…nsions

Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2022

Codecov Report

Merging #5615 (5119e4d) into main (da94dbb) will decrease coverage by 0.13%.
The diff coverage is 72.67%.

@@             Coverage Diff              @@
##               main    #5615      +/-   ##
============================================
- Coverage     71.09%   70.96%   -0.14%     
- Complexity    58499    58509      +10     
============================================
  Files          4748     4757       +9     
  Lines        278818   279093     +275     
  Branches      40296    40316      +20     
============================================
- Hits         198219   198050     -169     
- Misses        64477    64900     +423     
- Partials      16122    16143      +21     
Impacted Files Coverage Δ
...rch/extensions/rest/RestSendToExtensionAction.java 28.76% <16.66%> (+0.98%) ⬆️
...a/org/opensearch/extensions/ExtensionsManager.java 54.04% <29.16%> (-1.82%) ⬇️
...ch/extensions/action/ExtensionTransportAction.java 50.00% <50.00%> (ø)
...ns/action/TransportActionRequestFromExtension.java 69.23% <69.23%> (ø)
...nsions/action/ExtensionHandleTransportRequest.java 70.00% <70.00%> (ø)
...sions/action/ExtensionTransportActionsHandler.java 72.58% <72.58%> (ø)
...org/opensearch/extensions/ExtensionDependency.java 73.68% <73.68%> (ø)
...ensearch/extensions/rest/ExtensionRestRequest.java 77.27% <77.27%> (ø)
...ch/extensions/RegisterTransportActionsRequest.java 85.71% <92.30%> (-0.50%) ⬇️
...nsearch/extensions/rest/ExtensionRestResponse.java 95.45% <95.45%> (ø)
... and 496 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Ryan Bogan <rbogan@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@ryanbogan
Copy link
Member Author

@dblock @reta Thank you for all the feedback so far on these extensions PR's. This is the last one before we will be working completely on main. I would love to get this merged today if possible before everyone is gone for the holidays so can you take a look at some point today when you get a chance?

Signed-off-by: Ryan Bogan <rbogan@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dblock dblock merged commit 35605c6 into opensearch-project:main Dec 23, 2022
@ryanbogan ryanbogan added the backport 2.x Backport to 2.x branch label Dec 23, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-5615-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 35605c696b2735f66ce7ae81f228a800df20c1d0
# Push it to GitHub
git push --set-upstream origin backport/backport-5615-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-5615-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants