Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky SegmentReplicationITs. #6015

Merged
merged 4 commits into from
Jan 27, 2023
Merged

Fix flaky SegmentReplicationITs. #6015

merged 4 commits into from
Jan 27, 2023

Commits on Jan 26, 2023

  1. Fix flaky SegmentReplicationITs.

    This change fixes flakiness with segment replication ITs.
    It does this by updating the wait condition used to ensure replicas are up to date
    to wait until a searched docCount is reached instead of output of the Segments API that can change
    if there are concurrent refreshes.
    It also does this by updating the method used to assert segment stats to wait until the assertion holds true rather
    than at a point in time.  This method is also updated to assert store metadata directly over API output.
    
    Signed-off-by: Marc Handalian <handalm@amazon.com>
    mch2 committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    030a6e1 View commit details
    Browse the repository at this point in the history
  2. Fix error message to print expected and actual doc counts.

    Signed-off-by: Marc Handalian <handalm@amazon.com>
    mch2 committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    66f9042 View commit details
    Browse the repository at this point in the history
  3. PR feedback.

    Signed-off-by: Marc Handalian <handalm@amazon.com>
    mch2 committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    eb6f377 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2023

  1. spotless.

    Signed-off-by: Marc Handalian <handalm@amazon.com>
    mch2 committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    555492f View commit details
    Browse the repository at this point in the history