Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flakiness of testQueryFiltering due to error bound #7317

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

austintlee
Copy link
Contributor

Description

This change addresses an inappropriate/incorrect error bound on TDigest estimates on medians used in MedianAbsoluteDeviationAggregatorTests. TDigest algorithm's error is proportional to q*(1-q) where q is the percentile and is at worst in the middle (median). 0.1 is more appropriate for 90 percentile (q = 0.9).

Issues Resolved

#4789

Check List

  • New functionality includes testing.
    • [x ] All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • [ x] Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Austin Lee <austin.t.lee@gmail.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.common.util.concurrent.QueueResizableOpenSearchThreadPoolExecutorTests.classMethod
      1 org.opensearch.gateway.RecoveryFromGatewayIT.testReuseInFileBasedPeerRecovery
      1 org.opensearch.common.util.concurrent.QueueResizableOpenSearchThreadPoolExecutorTests.testResizeQueueDown
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2023

Codecov Report

Merging #7317 (f6f6f32) into main (d984f50) will decrease coverage by 0.08%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #7317      +/-   ##
============================================
- Coverage     70.71%   70.64%   -0.08%     
+ Complexity    59497    59485      -12     
============================================
  Files          4859     4859              
  Lines        285339   285339              
  Branches      41133    41133              
============================================
- Hits         201772   201570     -202     
- Misses        66965    67181     +216     
+ Partials      16602    16588      -14     

see 473 files with indirect coverage changes

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but cc:ing @tdunning in case we get our math wrong 😅

@dblock dblock added the backport 2.x Backport to 2.x branch label Apr 28, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 28, 2023
Signed-off-by: Austin Lee <austin.t.lee@gmail.com>
(cherry picked from commit 611e007)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal pushed a commit that referenced this pull request May 2, 2023
(cherry picked from commit 611e007)

Signed-off-by: Austin Lee <austin.t.lee@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…oject#7317)

Signed-off-by: Austin Lee <austin.t.lee@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants