Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remote Segment Store] Add Lucene major version to UploadedSegmentMetadata #8088

Merged
merged 16 commits into from
Jul 21, 2023
Merged

[Remote Segment Store] Add Lucene major version to UploadedSegmentMetadata #8088

merged 16 commits into from
Jul 21, 2023

Commits on Jul 21, 2023

  1. Add Lucene version to UploadedSegmentMetadata 

    Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
    Bhumika Saini committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    270e03a View commit details
    Browse the repository at this point in the history

  2. Update tests and CHANGELOG 

    Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
    Bhumika Saini committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    61a4f96 View commit details
    Browse the repository at this point in the history

  3. Pass RemoteSegmentMetadataHandlerTests tests 

    Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
    Bhumika Saini committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    bfd9b3c View commit details
    Browse the repository at this point in the history

  4. Remove CHANGELOG entry, throw exception if lucene version is missing 

    Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
    Bhumika Saini committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    7dd7a5f View commit details
    Browse the repository at this point in the history

  5. Fix RemoteSegmentStoreDirectoryTests 

    Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
    Bhumika Saini committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    dcb6dbd View commit details
    Browse the repository at this point in the history

  6. Empty commit 

    Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
    Bhumika Saini committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    0a83f30 View commit details
    Browse the repository at this point in the history

  7. Refactor to use JUnit assertion 

    Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
    Bhumika Saini committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    d66113a View commit details
    Browse the repository at this point in the history

  8. Pass testUploadMetadataNonEmpty with changes from main 

    Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
    Bhumika Saini committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    e917b91 View commit details
    Browse the repository at this point in the history

  9. Rebase onto main 

    Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
    Bhumika Saini committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    acb5c87 View commit details
    Browse the repository at this point in the history

  10. Persist only Lucene major version in UploadedSegmentMetadata 

    Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
    Bhumika Saini committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    8aa0a86 View commit details
    Browse the repository at this point in the history

  11. Update UTs to only use Lucene major version in metadata 

    Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
    Bhumika Saini committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    6d3eafe View commit details
    Browse the repository at this point in the history

  12. Modularize the logic to extract Lucene major version for segments 

    Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
    Bhumika Saini committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    c0279eb View commit details
    Browse the repository at this point in the history

  13. Add UTs for getLuceneVersionForDocValuesUpdates() 

    Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
    Bhumika Saini committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    e1ce4e6 View commit details
    Browse the repository at this point in the history

  14. Use .si file's Lucene version for files without version info 

    Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
    Bhumika Saini committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    0e1adb4 View commit details
    Browse the repository at this point in the history

  15. Fix segment names in testUploadMetadataEmpty() 

    Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
    Bhumika Saini committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    de3324a View commit details
    Browse the repository at this point in the history

  16. Empty commit 

    Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
    Bhumika Saini committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    c795f71 View commit details
    Browse the repository at this point in the history