Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added transport action for bulk async shard fetch for primary shards #8218

Merged

Conversation

sudarshan-baliga
Copy link
Contributor

@sudarshan-baliga sudarshan-baliga commented Jun 22, 2023

Description

This PR for adding the transport action for the async fetching of the shard information for bulk of shards from the nodes in a single request per node. Code is inspired by the existing transport action TransportNodesListGatewayStartedShards.java which fetches just one shard information from the node per request.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

@amkhar amkhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sudarshan-baliga for creating a smaller PR.
Partially gone through it.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

sudarshan-baliga added a commit to Gaurav614/OpenSearch that referenced this pull request Jun 29, 2023
…roject#8218

Modify async replica shard fetch to use helper functions

Signed-off-by: sudarshan baliga <baliga108@gmail.com>
@shiv0408
Copy link
Member

shiv0408 commented Feb 1, 2024

Thanks for approval @shwetathareja!

Copy link
Contributor

github-actions bot commented Feb 1, 2024

❌ Gradle check result for 1dbd248: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Feb 1, 2024

❌ Gradle check result for f8d8a6a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shiv0408
Copy link
Member

shiv0408 commented Feb 1, 2024

testLuceneVersionConstant was failing as Lucene version was updated recently in #12072. Merged from main to resolve the failure.

Copy link
Contributor

github-actions bot commented Feb 1, 2024

❌ Gradle check result for d1e90a1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shiv0408
Copy link
Member

shiv0408 commented Feb 1, 2024

Build failure due to following already identified flaky test in #10006.

org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Copy link
Contributor

github-actions bot commented Feb 1, 2024

❕ Gradle check result for 8f113fc: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@shwetathareja shwetathareja merged commit 8cb4bb4 into opensearch-project:main Feb 2, 2024
32 of 33 checks passed
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
…pensearch-project#8218)

* Added transport action for bulk async shard fetch for primary shards

Signed-off-by: sudarshan baliga <baliga108@gmail.com>
Co-authored-by: Shivansh Arora <hishiv@amazon.com>
shwetathareja pushed a commit that referenced this pull request Mar 14, 2024
* Add batch async shard fetch transport action for replica

Signed-off-by: sudarshan baliga <baliga108@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Signed-off-by: Aman Khare <amkhar@amazon.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
…pensearch-project#8218)

* Added transport action for bulk async shard fetch for primary shards

Signed-off-by: sudarshan baliga <baliga108@gmail.com>
Co-authored-by: Shivansh Arora <hishiv@amazon.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
…roject#8218 (opensearch-project#8356)

* Add batch async shard fetch transport action for replica

Signed-off-by: sudarshan baliga <baliga108@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Signed-off-by: Aman Khare <amkhar@amazon.com>
@amkhar amkhar added the backport 2.x Backport to 2.x branch label Mar 19, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-8218-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8cb4bb4c1776aaee3c4065c5a6b43e86a1e52daa
# Push it to GitHub
git push --set-upstream origin backport/backport-8218-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8218-to-2.x.

shiv0408 pushed a commit to shiv0408/OpenSearch that referenced this pull request Mar 19, 2024
…pensearch-project#8218)

* Added transport action for bulk async shard fetch for primary shards

Signed-off-by: Shivansh Arora <hishiv@amazon.com>

(cherry picked from commit 8cb4bb4)
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
shwetathareja pushed a commit that referenced this pull request Mar 19, 2024
…primary shards (#12759)

* Added transport action for bulk async shard fetch for primary shards (#8218)

* Added transport action for bulk async shard fetch for primary shards

Signed-off-by: Shivansh Arora <hishiv@amazon.com>

(cherry picked from commit 8cb4bb4)
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
shiv0408 added a commit to shiv0408/OpenSearch that referenced this pull request Mar 19, 2024
…roject#8218 (opensearch-project#8356)

* Add batch async shard fetch transport action for replica

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
(cherry picked from commit 12115d1)
shwetathareja pushed a commit that referenced this pull request Mar 19, 2024
#12770)

* Add batch async shard fetch transport action for replica

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
(cherry picked from commit 12115d1)
shiv0408 added a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…pensearch-project#8218)

* Added transport action for bulk async shard fetch for primary shards

Signed-off-by: sudarshan baliga <baliga108@gmail.com>
Co-authored-by: Shivansh Arora <hishiv@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…roject#8218 (opensearch-project#8356)

* Add batch async shard fetch transport action for replica

Signed-off-by: sudarshan baliga <baliga108@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Signed-off-by: Aman Khare <amkhar@amazon.com>
@shiv0408 shiv0408 self-assigned this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants