Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Created new ReplicaShardBatchAllocator #8961

Closed
wants to merge 1 commit into from

Conversation

shiv0408
Copy link
Member

@shiv0408 shiv0408 commented Jul 28, 2023

to be used instead of ReplicaShardAllocator for batch calls

Description

Sub PR part for overall improvement of #5098

Note :

  1. UTs and ITs will be added in upcoming commits.
  2. Gradle check will fail on compilation because this PR is dependent on multiple other PRs
  3. Not creating a helper class for common code as old PrimaryShardAllocator class will be deprecated in future.
  4. Most of the code is copy pasted from PrimaryShardAllocator class, only changes are handling of multiple shards metadata and handling of single DiscoveryNode object in response for a batch of shards.
  5. CHANGELOG will be updated only after last PR is raised(being merged) for this project.

Related Issues

Resolves #8960

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…hardAllocator for batch calls

Signed-off-by: Shivansh Arora <shivansh.arora@protonmail.com>
@shiv0408 shiv0408 changed the title Created new ReplicaShardBatchAllocator [DRAFT] Created new ReplicaShardBatchAllocator Jul 28, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@shiv0408 shiv0408 closed this Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add a batch allocator for building allocation decisions for multiple primary & replica shards
1 participant