Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remote Cluster State] Parallel and Multipart IndexMetadata uploads #9664

Merged
merged 14 commits into from
Sep 6, 2023
Merged

[Remote Cluster State] Parallel and Multipart IndexMetadata uploads #9664

merged 14 commits into from
Sep 6, 2023

Conversation

linuxpi
Copy link
Collaborator

@linuxpi linuxpi commented Aug 31, 2023 •
edited
Loading

Description

  • Adds support for parallel and multipart uploads via ChecksumBlobstoreFormat
  • Use new writeAsync for writing Remote cluster metadata to remote. This ensures parallel upload of IndexMetadata files to speed up remote cluster state sync

Related Issues

Resolves #9570

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@linuxpi linuxpi marked this pull request as ready for review August 31, 2023 11:13
@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 7a6cd4e

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2023

Compatibility status:

Checks if related components are compatible with change d3ba955

Incompatible components

Skipped components

Compatible components

@linuxpi
Minor refactoring
4705057 
Signed-off-by: bansvaru <bansvaru@amazon.com>
@linuxpi
remove docstring causing build failure
a41fd4b 
Signed-off-by: bansvaru <bansvaru@amazon.com>
@linuxpi
fix/add UTs
7dd676b 
Signed-off-by: bansvaru <bansvaru@amazon.com>
@linuxpi
fix spotless errors
ebcb720 
Signed-off-by: bansvaru <bansvaru@amazon.com>
@linuxpi
add UTs for async upload in RemoteClusterStateServiceTests
d5f512f 
Signed-off-by: bansvaru <bansvaru@amazon.com>
@linuxpi
Empty Commit
7b4de88 
Signed-off-by: bansvaru <bansvaru@amazon.com>
@linuxpi
address PR comments
b8a1026 
Signed-off-by: bansvaru <bansvaru@amazon.com>
@linuxpi
add more assertions on successful parallel upload
882984c 
Signed-off-by: bansvaru <bansvaru@amazon.com>
@linuxpi
Empty Commit
a3029fb 
Signed-off-by: bansvaru <bansvaru@amazon.com>
@linuxpi linuxpi force-pushed the remote-cluster-state-parallel-upload branch from 90684e5 to a3029fb Compare September 6, 2023 16:26
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Gradle Check (Jenkins) Run Completed with:

@shwetathareja shwetathareja merged commit 92b2095 into opensearch-project:main Sep 6, 2023
8 of 9 checks passed
@linuxpi linuxpi deleted the remote-cluster-state-parallel-upload branch September 6, 2023 16:50
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Compatibility status:

Checks if related components are compatible with change a3029fb

Incompatible components

Incompatible components: [https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/reporting.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Gradle Check (Jenkins) Run Completed with:

@shwetathareja shwetathareja added the backport 2.x Backport to 2.x branch label Sep 6, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 6, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 6, 2023
@github-actions
[Remote Cluster State] Parallel and Multipart IndexMetadata uploads (#…
13017c4 
…9664)

* [Remote Cluster State] Parallel and Multipart IndexMetadata uploads

Signed-off-by: bansvaru <bansvaru@amazon.com>
(cherry picked from commit 92b2095)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale pushed a commit that referenced this pull request Sep 7, 2023
@opensearch-trigger-bot @github-actions
[Remote Cluster State] Parallel and Multipart IndexMetadata uploads (#…
49fc823 
…9664) (#9838)

* [Remote Cluster State] Parallel and Multipart IndexMetadata uploads


(cherry picked from commit 92b2095)

Signed-off-by: bansvaru <bansvaru@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@sachinpkale sachinpkale added the backport 2.10 Backport to 2.10 branch label Sep 7, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 7, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 7, 2023
@github-actions
[Remote Cluster State] Parallel and Multipart IndexMetadata uploads (#…
8603c7b 
…9664)

* [Remote Cluster State] Parallel and Multipart IndexMetadata uploads

Signed-off-by: bansvaru <bansvaru@amazon.com>
(cherry picked from commit 92b2095)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale pushed a commit that referenced this pull request Sep 7, 2023
@opensearch-trigger-bot @github-actions
[Remote Cluster State] Parallel and Multipart IndexMetadata uploads (#…
d81b63b 
…9664) (#9861)

* [Remote Cluster State] Parallel and Multipart IndexMetadata uploads


(cherry picked from commit 92b2095)

Signed-off-by: bansvaru <bansvaru@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
@linuxpi @kaushalmahi12
[Remote Cluster State] Parallel and Multipart IndexMetadata uploads (o…
4f1eeb7 
…pensearch-project#9664)

* [Remote Cluster State] Parallel and Multipart IndexMetadata uploads

Signed-off-by: bansvaru <bansvaru@amazon.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
@linuxpi @brusic
[Remote Cluster State] Parallel and Multipart IndexMetadata uploads (o…
812b05b 
…pensearch-project#9664)

* [Remote Cluster State] Parallel and Multipart IndexMetadata uploads

Signed-off-by: bansvaru <bansvaru@amazon.com>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
@shiv0408 shiv0408 assigned shiv0408 and unassigned shiv0408 Apr 1, 2024
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@linuxpi @shiv0408
[Remote Cluster State] Parallel and Multipart IndexMetadata uploads (o…
510075a 
…pensearch-project#9664)

* [Remote Cluster State] Parallel and Multipart IndexMetadata uploads

Signed-off-by: bansvaru <bansvaru@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
@gbbafna gbbafna mentioned this pull request Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrross andrross andrross left review comments

@sachinpkale sachinpkale sachinpkale approved these changes

@shwetathareja shwetathareja shwetathareja approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@peternied peternied Awaiting requested review from peternied

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch backport 2.10 Backport to 2.10 branch Cluster Manager skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Remote State] Parallel upload of metadata files to remote repo
5 participants
@linuxpi @shwetathareja @sachinpkale @andrross @shiv0408