Validate MockTracingTelemetry span state on shutdown. #9818

Gaganjuneja · 2023-09-06T13:11:02Z

Description

Mock telemetry show allow the option to do strict checking of all the spans' state at the cluster shutdown specifically for the Integration tests.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

New functionality includes testing.
All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2023-09-06T13:40:09Z

Compatibility status:

Checks if related components are compatible with change 3b553ad

Incompatible components

Incompatible components: [https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/neural-search.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

github-actions · 2023-09-06T13:45:59Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/24633/
CommitID: 3b553ad
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-09-06T16:37:00Z

Compatibility status:

Checks if related components are compatible with change 0bc2903

Incompatible components

Incompatible components: [https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/neural-search.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

github-actions · 2023-09-06T16:52:44Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/24678/
CommitID: 0bc2903
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Gaganjuneja · 2023-09-06T16:55:15Z

Flaky tests -

org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards
org.opensearch.remotestore.RemoteStoreStatsIT.testStatsResponseFromLocalNode
org.opensearch.remotestore.RemoteStoreStatsIT.testStatsResponseAllShards
org.opensearch.search.profile.query.QueryProfilerIT.testProfileMatchesRegular
org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing
org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

github-actions · 2023-09-06T17:34:48Z

Compatibility status:

Checks if related components are compatible with change 0482b8b

Incompatible components

Incompatible components: [https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/neural-search.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

github-actions · 2023-09-06T17:39:04Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/24692/
CommitID: 0482b8b
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

github-actions · 2023-09-06T18:16:41Z

Compatibility status:

Checks if related components are compatible with change 6bbeffe

Incompatible components

Incompatible components: [https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git]

github-actions · 2023-09-06T18:29:02Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/24718/
CommitID: 6bbeffe

codecov · 2023-09-06T18:30:40Z

Codecov Report

Merging #9818 (6bbeffe) into main (76f1b52) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #9818      +/-   ##
============================================
- Coverage     71.15%   71.12%   -0.03%     
+ Complexity    58146    58128      -18     
============================================
  Files          4835     4835              
  Lines        273969   273969              
  Branches      39910    39910              
============================================
- Hits         194939   194869      -70     
- Misses        62653    62751      +98     
+ Partials      16377    16349      -28

see 492 files with indirect coverage changes

Gaganjuneja · 2023-09-06T18:34:56Z

@reta, Request to merge this PR. Thanks!

* Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com> (cherry picked from commit 9b26bd9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Address review comment * Address review comment * Address review comment * Empty-Commit --------- (cherry picked from commit 9b26bd9) Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>

kotwanikunal · 2023-09-06T20:15:38Z

Does this need to go in 2.10 as well? @reta @Gaganjuneja
Please add the backport 2.10 label in that case.

reta · 2023-09-06T20:40:50Z

Please add the backport 2.10 label in that case.

Done, thanks a lot @kotwanikunal !

* Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com> (cherry picked from commit 9b26bd9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Address review comment * Address review comment * Address review comment * Empty-Commit --------- (cherry picked from commit 9b26bd9) Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>

…ject#9818) * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

…ject#9818) * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>

…ject#9818) * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>

Gaganjuneja mentioned this pull request Sep 6, 2023

Add Tracing Instrumentation at Network and Rest layer #9415

Merged

6 tasks

Gaganjuneja added the skip-changelog label Sep 6, 2023

Gaganjuneja changed the title ~~Validate MockTracingTelemetry state on shutdown.~~ Validate MockTracingTelemetry span state on shutdown. Sep 6, 2023

Gagan Juneja added 4 commits September 6, 2023 23:16

Address review comment

65cb23b

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

Address review comment

edf60a3

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

Address review comment

df58f96

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

Empty-Commit

6bbeffe

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

Gaganjuneja force-pushed the main-telemetry-strict-check branch from 0482b8b to 6bbeffe Compare September 6, 2023 17:47

reta merged commit 9b26bd9 into opensearch-project:main Sep 6, 2023
11 checks passed

reta added the backport 2.x Backport to 2.x branch label Sep 6, 2023

opensearch-trigger-bot bot mentioned this pull request Sep 6, 2023

[Backport 2.x] Validate MockTracingTelemetry span state on shutdown. #9841

Merged

reta added v2.10.0 backport 2.10 Backport to 2.10 branch and removed v2.10.0 labels Sep 6, 2023

opensearch-trigger-bot bot mentioned this pull request Sep 6, 2023

[Backport 2.10] Validate MockTracingTelemetry span state on shutdown. #9843

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Validate MockTracingTelemetry span state on shutdown. #9818

Validate MockTracingTelemetry span state on shutdown. #9818

Gaganjuneja commented Sep 6, 2023

github-actions bot commented Sep 6, 2023

github-actions bot commented Sep 6, 2023

github-actions bot commented Sep 6, 2023

github-actions bot commented Sep 6, 2023

Gaganjuneja commented Sep 6, 2023

github-actions bot commented Sep 6, 2023

github-actions bot commented Sep 6, 2023

github-actions bot commented Sep 6, 2023

github-actions bot commented Sep 6, 2023

codecov bot commented Sep 6, 2023

Gaganjuneja commented Sep 6, 2023

kotwanikunal commented Sep 6, 2023

reta commented Sep 6, 2023

Validate MockTracingTelemetry span state on shutdown. #9818

Validate MockTracingTelemetry span state on shutdown. #9818

Conversation

Gaganjuneja commented Sep 6, 2023

Description

Related Issues

Check List

github-actions bot commented Sep 6, 2023

Compatibility status:

Incompatible components

Skipped components

Compatible components

github-actions bot commented Sep 6, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Sep 6, 2023

Compatibility status:

Incompatible components

Skipped components

Compatible components

github-actions bot commented Sep 6, 2023

Gradle Check (Jenkins) Run Completed with:

Gaganjuneja commented Sep 6, 2023

github-actions bot commented Sep 6, 2023

Compatibility status:

Incompatible components

Skipped components

Compatible components

github-actions bot commented Sep 6, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Sep 6, 2023

Compatibility status:

Incompatible components

Skipped components

Compatible components

github-actions bot commented Sep 6, 2023

Gradle Check (Jenkins) Run Completed with:

codecov bot commented Sep 6, 2023

Codecov Report

Gaganjuneja commented Sep 6, 2023

kotwanikunal commented Sep 6, 2023

reta commented Sep 6, 2023