Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bugs associated with alerts table, and addressed UX review feedback. #222

Merged
merged 8 commits into from
Apr 21, 2022

Conversation

AWSHurneyt
Copy link
Collaborator

Description

  1. Refactored alerts table to display finding doc IDs.
  2. Fixed a bug that was preventing the alerts flyout table from refreshing after acknowledging alerts.
  3. Removed edit monitor button from alerts table on monitor details page.
  4. Fixed a bug that was causing the monitor create/update page to crash when changing from extraction editor to visual editor.
  5. Refactored position of finding flyout.
  6. Fixed a bug that was preventing sorting and pagination of the findings table.
  7. Repurposed QueryPopover to FindingsPopover, and added support for displaying doc IDs using the popover.
  8. Removed parentheses from the trigger condition sent to backend.
  9. Added validation for queries defined using the visual editor.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
… API.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
…was preventing the alerts flyout table from refreshing after acknowledging alerts. Removed edit monitor button from alerts table on monitor details page. Fixed a bug that was causing the monitor create/update page to crash when changing from extraction editor to visual editor. Refactored position of finding flyout. Fixed a bug that was preventing sorting and pagination of the findings table. Repurposed QueryPopover to FindingsPopover, and added support for displaying doc IDs using the popover. Removed parentheses from the trigger condition sent to backend. Added validation for queries defined using the visual editor.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@AWSHurneyt AWSHurneyt marked this pull request as ready for review April 20, 2022 20:11
@AWSHurneyt AWSHurneyt requested a review from a team April 20, 2022 20:11
lezzago
lezzago previously approved these changes Apr 20, 2022
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #222 (7afdddc) into main (fbea210) will decrease coverage by 0.52%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #222      +/-   ##
==========================================
- Coverage   53.22%   52.70%   -0.53%     
==========================================
  Files         211      209       -2     
  Lines        5257     5311      +54     
  Branches      710      724      +14     
==========================================
+ Hits         2798     2799       +1     
- Misses       2457     2510      +53     
  Partials        2        2              
Impacted Files Coverage Δ
...youts/components/AlertsDashboardFlyoutComponent.js 50.95% <0.00%> (-2.64%) ⬇️
...eMonitor/containers/DefineMonitor/DefineMonitor.js 68.58% <0.00%> (-1.79%) ⬇️
...oard/components/FindingsDashboard/FindingFlyout.js 4.54% <0.00%> (ø)
...ions/components/createDestinations/Email/Sender.js 13.63% <0.00%> (ø)
...ns/containers/DestinationsList/DestinationsList.js 52.94% <0.00%> (ø)
...s/components/createDestinations/Webhook/Webhook.js 30.00% <0.00%> (ø)
.../components/createDestinations/Email/EmailGroup.js 13.63% <0.00%> (ø)
.../containers/CreateDestination/CreateDestination.js 3.79% <0.00%> (ø)
...onents/createDestinations/CustomWebhook/URLInfo.js 16.00% <0.00%> (ø)
...iners/CreateDestination/EmailSender/EmailSender.js 2.85% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbea210...7afdddc. Read the comment docs.

@AWSHurneyt AWSHurneyt merged commit 7180f8a into opensearch-project:main Apr 21, 2022
AWSHurneyt added a commit that referenced this pull request Apr 21, 2022
* Fixed a bug that was preventing the configured schedule from displaying when editing a monitor that was created through backend commands. Added cypress tests to verify fix. (#197)

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed bugs associated with alerts table, and addressed UX review feedback. (#222)

* Removed unsupported prop from EuiGrid.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Increased limit of doc level trigger conditions.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored empty dashboard button based on UX feedback.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored query performance text based on UX feedback.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored logic to apply default sortField value for the getAlerts API.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored logic to apply default sortField value for the getFindings API.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored alerts table to display finding doc IDs. Fixed a bug that was preventing the alerts flyout table from refreshing after acknowledging alerts. Removed edit monitor button from alerts table on monitor details page. Fixed a bug that was causing the monitor create/update page to crash when changing from extraction editor to visual editor. Refactored position of finding flyout. Fixed a bug that was preventing sorting and pagination of the findings table. Repurposed QueryPopover to FindingsPopover, and added support for displaying doc IDs using the popover. Removed parentheses from the trigger condition sent to backend. Added validation for queries defined using the visual editor.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated snapshots, and implemented fix for a unit test.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added document column to alerts dashboard for doc level monitors. Adjusted alerts dashboard configuration to remove unused alert states for doc level monitors. Refactored style of alerts flyout based on UX feedback. (#223)

* Removed unsupported prop from EuiGrid.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Increased limit of doc level trigger conditions.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored empty dashboard button based on UX feedback.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored query performance text based on UX feedback.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored logic to apply default sortField value for the getAlerts API.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored logic to apply default sortField value for the getFindings API.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored alerts table to display finding doc IDs. Fixed a bug that was preventing the alerts flyout table from refreshing after acknowledging alerts. Removed edit monitor button from alerts table on monitor details page. Fixed a bug that was causing the monitor create/update page to crash when changing from extraction editor to visual editor. Refactored position of finding flyout. Fixed a bug that was preventing sorting and pagination of the findings table. Repurposed QueryPopover to FindingsPopover, and added support for displaying doc IDs using the popover. Removed parentheses from the trigger condition sent to backend. Added validation for queries defined using the visual editor.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated snapshots, and implemented fix for a unit test.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added document column to alerts dashboard for doc level monitors. Adjusted alerts dashboard configuration to remove unused alert states for doc level monitors. Refactored style of alerts flyout based on UX feedback.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated snapshot.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt added a commit to AWSHurneyt/alerting-dashboards-plugin that referenced this pull request Jun 10, 2022
* Fixed a bug that was preventing the configured schedule from displaying when editing a monitor that was created through backend commands. Added cypress tests to verify fix. (opensearch-project#197)

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed bugs associated with alerts table, and addressed UX review feedback. (opensearch-project#222)

* Removed unsupported prop from EuiGrid.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Increased limit of doc level trigger conditions.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored empty dashboard button based on UX feedback.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored query performance text based on UX feedback.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored logic to apply default sortField value for the getAlerts API.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored logic to apply default sortField value for the getFindings API.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored alerts table to display finding doc IDs. Fixed a bug that was preventing the alerts flyout table from refreshing after acknowledging alerts. Removed edit monitor button from alerts table on monitor details page. Fixed a bug that was causing the monitor create/update page to crash when changing from extraction editor to visual editor. Refactored position of finding flyout. Fixed a bug that was preventing sorting and pagination of the findings table. Repurposed QueryPopover to FindingsPopover, and added support for displaying doc IDs using the popover. Removed parentheses from the trigger condition sent to backend. Added validation for queries defined using the visual editor.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated snapshots, and implemented fix for a unit test.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added document column to alerts dashboard for doc level monitors. Adjusted alerts dashboard configuration to remove unused alert states for doc level monitors. Refactored style of alerts flyout based on UX feedback. (opensearch-project#223)

* Removed unsupported prop from EuiGrid.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Increased limit of doc level trigger conditions.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored empty dashboard button based on UX feedback.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored query performance text based on UX feedback.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored logic to apply default sortField value for the getAlerts API.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored logic to apply default sortField value for the getFindings API.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored alerts table to display finding doc IDs. Fixed a bug that was preventing the alerts flyout table from refreshing after acknowledging alerts. Removed edit monitor button from alerts table on monitor details page. Fixed a bug that was causing the monitor create/update page to crash when changing from extraction editor to visual editor. Refactored position of finding flyout. Fixed a bug that was preventing sorting and pagination of the findings table. Repurposed QueryPopover to FindingsPopover, and added support for displaying doc IDs using the popover. Removed parentheses from the trigger condition sent to backend. Added validation for queries defined using the visual editor.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated snapshots, and implemented fix for a unit test.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added document column to alerts dashboard for doc level monitors. Adjusted alerts dashboard configuration to remove unused alert states for doc level monitors. Refactored style of alerts flyout based on UX feedback.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated snapshot.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants