Removed the rc1 qualifier from the plugin version, changed OSD version used by test workflows to 2.0, added test environment. #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt
changed the title
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
…escape-handling logic for the component that were introduced by newer versions of EUI. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
…cific methods. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt
changed the title
Codecov Report
@@ Coverage Diff @@
## main #238 +/- ##
==========================================
- Coverage 52.15% 52.00% -0.15%
==========================================
Files 209 209
Lines 5407 5407
Branches 741 741
==========================================
- Hits 2820 2812 -8
- Misses 2585 2593 +8
Partials 2 2
Continue to review full report at Codecov.
|
lezzago
approved these changes
May 12, 2022
downsrob
approved these changes
May 13, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 13, 2022
…n used by test workflows to 2.0, added test environment. (#238) * Removed the rc1 qualifier from the plugin version. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Adjusted version of OpenSearch-Dashboards used by test workflows. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added testEnvironment to jest.config.js. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Set a failing test to skip. The test broke as a result of changes to escape-handling logic for the component that were introduced by newer versions of EUI. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored the way some failing tests were listening for calls to specific methods. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit e1580e1)
lezzago
pushed a commit
that referenced
this pull request
May 16, 2022
…n used by test workflows to 2.0, added test environment. (#238) (#239) * Removed the rc1 qualifier from the plugin version. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Adjusted version of OpenSearch-Dashboards used by test workflows. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added testEnvironment to jest.config.js. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Set a failing test to skip. The test broke as a result of changes to escape-handling logic for the component that were introduced by newer versions of EUI. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored the way some failing tests were listening for calls to specific methods. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit e1580e1) Co-authored-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt
added a commit
to AWSHurneyt/alerting-dashboards-plugin
that referenced
this pull request
Jun 10, 2022
…n used by test workflows to 2.0, added test environment. (opensearch-project#238) (opensearch-project#239) * Removed the rc1 qualifier from the plugin version. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Adjusted version of OpenSearch-Dashboards used by test workflows. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added testEnvironment to jest.config.js. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Set a failing test to skip. The test broke as a result of changes to escape-handling logic for the component that were introduced by newer versions of EUI. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored the way some failing tests were listening for calls to specific methods. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit e1580e1) Co-authored-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: AWSHurneyt hurneyt@amazon.com
Description
2.0.jest.config.js.Issues Resolved
#233
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.