add dashboard context menus #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d monitors flyout
23 tasks
lezzago
approved these changes
Mar 21, 2023
|
Approving as this is going to be a testing feature branch and will need a proper review before going to main |
amsiglan
reviewed
Mar 21, 2023
| }; | ||
|
|
||
| return ( | ||
| <div className="associated-monitors"> |
There was a problem hiding this comment.
This should be EuiFlyout instead of div? Or is there a container flyout somewhere else that I missed?
There was a problem hiding this comment.
Correct, there is a container Flyout that this component is launched within. In the utils/contextMenu/getActions.tsx you can see where the flyout is created.
amsiglan
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a context menu in the main Dashboard to view and manage alerts
Dependent on this dashboards PR
opensearch-project/OpenSearch-Dashboards#3169
Issues Resolved
#459
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.