Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a unit test. #576

Merged
merged 5 commits into from
Jun 15, 2023
Merged

Conversation

AWSHurneyt
Copy link
Collaborator

@AWSHurneyt AWSHurneyt commented Jun 15, 2023

Description

Fixed a unit test that started failing.

Issues Resolved

#555

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #576 (2cdc642) into main (c1a6972) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #576      +/-   ##
==========================================
+ Coverage   52.82%   52.86%   +0.03%     
==========================================
  Files         212      212              
  Lines        5594     5594              
  Branches      782      782              
==========================================
+ Hits         2955     2957       +2     
+ Misses       2637     2635       -2     
  Partials        2        2              

see 1 file with indirect coverage changes

@AWSHurneyt AWSHurneyt marked this pull request as ready for review June 15, 2023 18:47
@AWSHurneyt AWSHurneyt changed the title Fixed a unit test that started failing after bump to node 18. Fixed a unit test. Jun 15, 2023
@AWSHurneyt
Copy link
Collaborator Author

The cypress workflow is expected to fail on main at the moment. This PR in my personal repo executes the tests against the 2.x branch AWSHurneyt#10

package.json Show resolved Hide resolved
@AWSHurneyt AWSHurneyt merged commit 353aa25 into opensearch-project:main Jun 15, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 26, 2023
* Fixed a unit test that started failing after bump tp node 18.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a unit test that started failing after bump tp node 18.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Bumped lint-staged version.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a unit test that started failing after bump tp node 18.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated snapshot.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

---------

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
(cherry picked from commit 353aa25)
lezzago added a commit that referenced this pull request Jun 30, 2023
* Fixed a unit test that started failing after bump tp node 18.



* Fixed a unit test that started failing after bump tp node 18.



* Bumped lint-staged version.



* Fixed a unit test that started failing after bump tp node 18.



* Updated snapshot.



---------

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Co-authored-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt added a commit that referenced this pull request Jul 6, 2023
* Fixed a unit test that started failing after bump tp node 18.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a unit test that started failing after bump tp node 18.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Bumped lint-staged version.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a unit test that started failing after bump tp node 18.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated snapshot.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

---------

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
(cherry picked from commit 353aa25)

Co-authored-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants