-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use alerting models and dtos from common-utils dependencies. #592
Conversation
…ensearch-project#503) * Version increment automation Signed-off-by: pgodithi <pgodithi@amazon.com> * Version increment automation: task rename updateVersion Signed-off-by: pgodithi <pgodithi@amazon.com> (cherry picked from commit 3b8bfe7) Signed-off-by: prudhvigodithi <pgodithi@amazon.com> Co-authored-by: Prudhvi Godithi <pgodithi@amazon.com>
…rch-project#499) As per gradle [docs] add support to remove timestamps and package with same order which is required from [reproducible] builds [docs]: https://docs.gradle.org/current/userguide/working_with_files.html#sec:archives [reproducible]: https://reproducible-builds.org/ Signed-off-by: Leonidas Spyropoulos <artafinde@archlinux.org> (cherry picked from commit a27d5a2) Signed-off-by: prudhvigodithi <pgodithi@amazon.com> Co-authored-by: Leonidas Spyropoulos <artafinde@gmail.com>
….1.0.0 zip following deprecation of ODFE. (opensearch-project#510) (opensearch-project#512) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit fea6b4a) Co-authored-by: AWSHurneyt <hurneyt@amazon.com>
…ersion from 4.3.1 to 4.6.1. (opensearch-project#506) Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
* Added 2.2 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.2 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
* Bumped 2.x branch from version 2.2.0 to 2.3.0. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Bumped mockito core version. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
…h-project#549) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
* Added 2.3 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.3 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
…ject#556) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
…oject#569) Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
…roject#570) (opensearch-project#571) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> (cherry picked from commit 3a844f8) Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
opensearch-project#577) Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #592 +/- ##
============================================
- Coverage 76.99% 76.32% -0.67%
+ Complexity 178 116 -62
============================================
Files 167 127 -40
Lines 8576 6455 -2121
Branches 1270 926 -344
============================================
- Hits 6603 4927 -1676
+ Misses 1337 1054 -283
+ Partials 636 474 -162
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Can we cherry-pick the 2.x commits and make the changes accordingly |
Can we reference the 2.x PRs that this is coming from? |
@lezzago have updated PR description with the same |
@@ -7,10 +7,10 @@ buildscript { | |||
apply from: 'build-tools/repositories.gradle' | |||
|
|||
ext { | |||
opensearch_version = System.getProperty("opensearch.version", "2.2.0-SNAPSHOT") | |||
opensearch_version = System.getProperty("opensearch.version", "2.4.0-SNAPSHOT") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also note in the PR description that we're bumping main
to 2.4.0
here if it's necessary for it to be in this PR. Ideally, we should separate it into another PR so it's easier to note when it happened in the commit history at a glance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's necessary in this PR. Have updated the description as suggested. thanks for pointing it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
2.x PRs, whose changes are being applied to main.
#577
#569
#568
#558
#556
This PR also bumps Alerting plugin to 2.4