Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Acknowledge Alert Request class loader issue #618

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

eirsep
Copy link
Member

@eirsep eirsep commented Oct 20, 2022

Change transport ack alerts action to accept Action Request and recreate as AckAlertRequest to fix Acknowledge Alert Request class loader issue

Solving the same issue we faced earlier with notifications for ack alerts flow : opensearch-project/common-utils#37

Signed-off-by: Surya Sashank Nistala snistala@amazon.com

…ate as AckAlertRequest

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
@eirsep eirsep requested review from a team, getsaurabh02 and sbcd90 October 20, 2022 19:31
@eirsep
Copy link
Member Author

eirsep commented Oct 20, 2022

Failure is from

org.opensearch.alerting.resthandler.FindingsRestApiIT > test find Finding by monitor id FAILED
    ParsingException[Failed to parse object: expecting token of type [START_OBJECT] but found [END_OBJECT]]
        at __randomizedtesting.SeedInfo.seed([CC40F800EF50801E:30D603E49DDE66AF]:0)
        at app//org.opensearch.common.xcontent.XContentParserUtils.parsingException(XContentParserUtils.java:[97](https://github.com/opensearch-project/alerting/actions/runs/3292387973/jobs/5427689051#step:4:98))
        at app//org.opensearch.common.xcontent.XContentParserUtils.ensureExpectedToken(XContentParserUtils.java:90)
        at app//org.opensearch.commons.alerting.model.FindingWithDocs$Companion.parse(FindingWithDocs.kt:59)
        at app//org.opensearch.alerting.AlertingRestTestCase.searchFindings(AlertingRestTestCase.kt:709)
        at app//org.opensearch.alerting.resthandler.FindingsRestApiIT.test fin

which is not related to this PR

this failure arises from common utils PR: fix security-analytics alerting findings api integration

@eirsep eirsep merged commit 2005185 into opensearch-project:main Oct 20, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 20, 2022
…ate as AckAlertRequest (#618)

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
(cherry picked from commit 2005185)
eirsep added a commit that referenced this pull request Oct 20, 2022
…ate as AckAlertRequest (#618) (#619)

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
(cherry picked from commit 2005185)

Co-authored-by: Surya Sashank Nistala <snistala@amazon.com>
sbcd90 pushed a commit to sbcd90/alerting that referenced this pull request Nov 2, 2022
…ate as AckAlertRequest (opensearch-project#618) (opensearch-project#619)

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
(cherry picked from commit 2005185)

Co-authored-by: Surya Sashank Nistala <snistala@amazon.com>
sbcd90 pushed a commit that referenced this pull request Nov 2, 2022
…ate as AckAlertRequest (#618) (#619)

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
(cherry picked from commit 2005185)

Co-authored-by: Surya Sashank Nistala <snistala@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants