Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix schema version in tests and delegate monitor metadata construction in tests #948

Merged
merged 4 commits into from
Jun 2, 2023

Conversation

eirsep
Copy link
Member

@eirsep eirsep commented Jun 1, 2023

unify single node tests verifying workflow behaviour into one single class
Tests verifying schema versions need to be updated as mappings for scheduled jobs and findings have been updated.
this PR is to fix schema version in tests for findings and scheduled jobs index mappings

Delegate monitor metadata verification fixed to assert the right metadata id.

…pings

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
…adata verification

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
@eirsep eirsep changed the title fix schema version in tests for findings and scheduled jobs index mappings fix schema version in tests and delegate monitor metadata construction in tests Jun 1, 2023
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #948 (5f4ce49) into main (89142f4) will decrease coverage by 1.34%.
The diff coverage is 66.12%.

@@             Coverage Diff              @@
##               main     #948      +/-   ##
============================================
- Coverage     76.07%   74.74%   -1.34%     
- Complexity      110      111       +1     
============================================
  Files           125      141      +16     
  Lines          7065     8263    +1198     
  Branches       1052     1206     +154     
============================================
+ Hits           5375     6176     +801     
- Misses         1153     1474     +321     
- Partials        537      613      +76     
Impacted Files Coverage Δ
...org/opensearch/alerting/model/destination/Chime.kt 80.00% <ø> (ø)
...search/alerting/model/destination/CustomWebhook.kt 96.10% <ø> (ø)
...org/opensearch/alerting/model/destination/Slack.kt 80.00% <ø> (ø)
...rch/alerting/model/destination/email/EmailGroup.kt 90.12% <ø> (ø)
.../org/opensearch/alerting/util/AlertingException.kt 71.42% <ø> (+7.14%) ⬆️
.../opensearch/alerting/util/AnomalyDetectionUtils.kt 100.00% <ø> (ø)
...destinationmigration/DestinationConversionUtils.kt 71.11% <ø> (+1.11%) ⬆️
...g/core/resthandler/RestScheduledJobStatsHandler.kt 96.55% <ø> (ø)
...org/opensearch/alerting/model/WorkflowRunResult.kt 24.00% <24.00%> (ø)
...n/org/opensearch/alerting/model/MonitorMetadata.kt 43.33% <33.33%> (-0.99%) ⬇️
... and 27 more

... and 11 files with indirect coverage changes

@getsaurabh02 getsaurabh02 merged commit 32c0bb0 into opensearch-project:main Jun 2, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 2, 2023
…n in tests (#948)

* fix schema version in tests for findings and scheduled jobs index mappings

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* fix workflow delegate monitor metadata construction in tests with metadata verification

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* unify all workflow transport tests

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* unify all single node tests into one single class

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

---------

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
(cherry picked from commit 32c0bb0)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 2, 2023
…n in tests (#948)

* fix schema version in tests for findings and scheduled jobs index mappings

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* fix workflow delegate monitor metadata construction in tests with metadata verification

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* unify all workflow transport tests

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* unify all single node tests into one single class

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

---------

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
(cherry picked from commit 32c0bb0)
eirsep added a commit that referenced this pull request Jun 2, 2023
…n in tests (#948) (#952)

* fix schema version in tests for findings and scheduled jobs index mappings

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* fix workflow delegate monitor metadata construction in tests with metadata verification

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* unify all workflow transport tests

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* unify all single node tests into one single class

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

---------

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
(cherry picked from commit 32c0bb0)

Co-authored-by: Surya Sashank Nistala <snistala@amazon.com>
eirsep added a commit that referenced this pull request Jun 2, 2023
…n in tests (#948) (#951)

* fix schema version in tests for findings and scheduled jobs index mappings

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* fix workflow delegate monitor metadata construction in tests with metadata verification

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* unify all workflow transport tests

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* unify all single node tests into one single class

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

---------

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
(cherry picked from commit 32c0bb0)

Co-authored-by: Surya Sashank Nistala <snistala@amazon.com>
@eirsep eirsep deleted the mapping-fix branch June 19, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants