Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra loading spinners #238

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

ohltyler
Copy link
Member

Signed-off-by: Tyler Ohlsen ohltyler@amazon.com

Description

Removes extra loading spinners on detector config page.

Issues Resolved

Closes #94

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler ohltyler requested review from a team, amitgalitz and ylwu-amzn April 12, 2022 22:40
@ohltyler ohltyler added bug Something isn't working and removed backport 1.x labels Apr 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2022

Codecov Report

Merging #238 (1abb61c) into main (6beefb9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #238   +/-   ##
=======================================
  Coverage   45.92%   45.92%           
=======================================
  Files         150      150           
  Lines        4956     4956           
  Branches      955      955           
=======================================
  Hits         2276     2276           
  Misses       2463     2463           
  Partials      217      217           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6beefb9...1abb61c. Read the comment docs.

@ohltyler ohltyler merged commit 29aa1dd into opensearch-project:main Apr 13, 2022
@ohltyler ohltyler deleted the remove-spinners branch April 13, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Showing 4 loading spinners when page is loading
4 participants