Add workflow to verify binary installation works #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
requested review from
ohltyler,
kaituo,
jackiehanyang,
amitgalitz,
sean-zheng-amazon,
dbwiddis,
owaiskazi19 and
joshpalis
as code owners
opensearch-trigger-bot
bot
added
github actions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #693 +/- ##
=======================================
Coverage 50.31% 50.31%
=======================================
Files 166 166
Lines 5595 5593 -2
Branches 1075 1057 -18
=======================================
- Hits 2815 2814 -1
Misses 2508 2508
+ Partials 272 271 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Derek Ho <dxho@amazon.com>
dbwiddis
previously approved these changes
Mar 22, 2024
Signed-off-by: Derek Ho <dxho@amazon.com>
…n-dashboards-plugin into binary-install
|
Thanks for the change! |
jackiehanyang
approved these changes
Apr 24, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 24, 2024
* Add workflow to verify binary installation works Signed-off-by: Derek Ho <dxho@amazon.com> * Fix name of renamed zip Signed-off-by: Derek Ho <dxho@amazon.com> * Add single version = loose flag Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit 41a1703)
jackiehanyang
pushed a commit
that referenced
this pull request
Apr 24, 2024
* Add workflow to verify binary installation works Signed-off-by: Derek Ho <dxho@amazon.com> * Fix name of renamed zip Signed-off-by: Derek Ho <dxho@amazon.com> * Add single version = loose flag Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit 41a1703) Co-authored-by: Derek Ho <derek01778@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have observed some issues within other plugins of issues being only caught at run time. This is because several things can go wrong during the build process, which may not be caught in a dev setup. This adds a workflow to verify that building and installing into OSD works on every PR.
Related issues:
opensearch-project/security-dashboards-plugin#1709
opensearch-project/security-analytics-dashboards-plugin#875
opensearch-project/dashboards-observability#309
opensearch-project/OpenSearch-Dashboards#5952
Issues Resolved
[List any issues this PR will resolve]
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.