Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure qualifier is default to alpha1 #123

Conversation

peterzhuamazon
Copy link
Member

Signed-off-by: Peter Zhu zhujiaxi@amazon.com

Description

Make sure qualifier is default to alpha1

Issues Resolved

#103

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
CEHENKLE
CEHENKLE previously approved these changes Mar 31, 2022
bbarani
bbarani previously approved these changes Mar 31, 2022
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon dismissed stale reviews from bbarani and CEHENKLE via befcd91 March 31, 2022 21:58
@peterzhuamazon
Copy link
Member Author

The errors are expected as we currently do not have security and PA ready for docker to run.

@peterzhuamazon
Copy link
Member Author

The image pulling of docker is success here.

@peterzhuamazon peterzhuamazon merged commit 3d0b82c into opensearch-project:main Mar 31, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-2.0.0-qualifier-default-3 branch March 31, 2022 22:31
@eirsep
Copy link
Member

eirsep commented Apr 1, 2022

Why was this merged before the CI is fixed? Our current PRs are failing CI.

@bbarani @peterzhuamazon @CEHENKLE

cc: @dhruv16dhr @bharath-techie @Bukhtawar

@dhruv16dhr
Copy link
Contributor

@CEHENKLE @dblock @peterzhuamazon

AsyncSearch plugin team is working on 2.0.0 open issues and have related PRs which are blocked as CI is failing due to this PR

Can this be reverted and merged back once docker image is available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants