Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change doc level query name validation #629

Closed
wants to merge 1 commit into from
Closed

Conversation

jowg-amazon
Copy link
Collaborator

Description

Changes the doc level query name validation to restrict the name from 1-256 characters, similar to the validation done on the front end

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: jowg-amazon <jowg@amazon.com>
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.91%. Comparing base (3f5421f) to head (6ed40de).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #629      +/-   ##
============================================
- Coverage     73.91%   73.91%   -0.01%     
  Complexity      891      891              
============================================
  Files           133      133              
  Lines          5870     5873       +3     
  Branches        717      718       +1     
============================================
+ Hits           4339     4341       +2     
  Misses         1219     1219              
- Partials        312      313       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jowg-amazon
Copy link
Collaborator Author

closing in favor of #630

@jowg-amazon jowg-amazon closed this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant