fix serde for monitor object in remote monitors #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
sbcd90
requested review from
lezzago,
bowenlan-amzn,
rishabhmaurya,
getsaurabh02,
eirsep,
AWSHurneyt,
engechas,
riysaxen-amzn and
jowg-amazon
as code owners
eirsep
approved these changes
Jun 28, 2024
riysaxen-amzn
approved these changes
Jun 28, 2024
jowg-amazon
approved these changes
Jun 28, 2024
jowg-amazon
pushed a commit
that referenced
this pull request
Jul 2, 2024
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
AWSHurneyt
added a commit
to AWSHurneyt/common-utils
that referenced
this pull request
Jul 2, 2024
fix serde for monitor (opensearch-project#692)
jowg-amazon
pushed a commit
that referenced
this pull request
Jul 2, 2024
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
jowg-amazon
pushed a commit
to jowg-amazon/common-utils
that referenced
this pull request
Jul 2, 2024
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
jowg-amazon
added a commit
that referenced
this pull request
Jul 2, 2024
* changes to add support for remote monitors in alerting (#661) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * changes to add support for remote monitors in alerting (#662) * changes to add support for remote monitors in alerting Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * add tests for moved classes Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> --------- Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * changes to support generic inputs and triggers in remote monitors (#664) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * add remote doc level monitor input (#665) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * fix serde of RemoteDocLevelMonitorInput (#666) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * fix serde for monitor (#692) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> --------- Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Co-authored-by: Subhobrata Dey <sbcd90@gmail.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 2, 2024
* changes to add support for remote monitors in alerting (#661) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * changes to add support for remote monitors in alerting (#662) * changes to add support for remote monitors in alerting Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * add tests for moved classes Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> --------- Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * changes to support generic inputs and triggers in remote monitors (#664) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * add remote doc level monitor input (#665) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * fix serde of RemoteDocLevelMonitorInput (#666) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * fix serde for monitor (#692) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> --------- Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Co-authored-by: Subhobrata Dey <sbcd90@gmail.com> (cherry picked from commit fbb297b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jowg-amazon
pushed a commit
that referenced
this pull request
Jul 2, 2024
* changes to add support for remote monitors in alerting (#661) * changes to add support for remote monitors in alerting (#662) * changes to add support for remote monitors in alerting * add tests for moved classes --------- * changes to support generic inputs and triggers in remote monitors (#664) * add remote doc level monitor input (#665) * fix serde of RemoteDocLevelMonitorInput (#666) * fix serde for monitor (#692) --------- (cherry picked from commit fbb297b) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Subhobrata Dey <sbcd90@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix serde for monitor object in remote monitors
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.