Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changing the names of the alerting comment actions #724

Merged
merged 1 commit into from
Sep 3, 2024
Merged

changing the names of the alerting comment actions #724

merged 1 commit into from
Sep 3, 2024

Conversation

toepkerd
Copy link
Contributor

@toepkerd toepkerd commented Sep 2, 2024 •
edited
Loading

Description

Modifying the alerting comments permissions to not be put under alerting/alerts. With the way alerting_ack_alerts is currently configured in Security plugin, putting comments permissions under alerting/alerts would give someone with alerting_ack_alerts role full access to alerting comments (including edit and delete)

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@toepkerd-zz
changing the names of the alerting comment actions
746fdfc 
Signed-off-by: Dennis Toepker <toepkerd@amazon.com>
@toepkerd toepkerd marked this pull request as ready for review September 2, 2024 19:22
eirsep
eirsep reviewed Sep 3, 2024
View reviewed changes
src/main/kotlin/org/opensearch/commons/alerting/action/AlertingActions.kt
const val INDEX_COMMENT_ACTION_NAME = "cluster:admin/opensearch/alerting/alerts/comments/write"
const val SEARCH_COMMENTS_ACTION_NAME = "cluster:admin/opensearch/alerting/alerts/comments/search"
const val DELETE_COMMENT_ACTION_NAME = "cluster:admin/opensearch/alerting/alerts/comments/delete"
const val INDEX_COMMENT_ACTION_NAME = "cluster:admin/opensearch/alerting/comments/write"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to make any corresponding changes in security plugin's alerting cluster permissions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i haven't raised a PR to security plugin just yet. this PR is in preparation for the security plugin PR where I do add these permissions to the roles.

eirsep
eirsep requested changes Sep 3, 2024
View reviewed changes
Copy link
Member

@eirsep eirsep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz update description as to why we are making this change

@AWSHurneyt AWSHurneyt merged commit 6a4c248 into opensearch-project:main Sep 3, 2024
9 of 11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 3, 2024
@github-actions @toepkerd-zz
changing the names of the alerting comment actions (#724)
7308bdb 
Signed-off-by: Dennis Toepker <toepkerd@amazon.com>
Co-authored-by: Dennis Toepker <toepkerd@amazon.com>
(cherry picked from commit 6a4c248)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 3, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 3, 2024
@github-actions @toepkerd-zz
changing the names of the alerting comment actions (#724)
97d0380 
Signed-off-by: Dennis Toepker <toepkerd@amazon.com>
Co-authored-by: Dennis Toepker <toepkerd@amazon.com>
(cherry picked from commit 6a4c248)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 3, 2024
Merged
jowg-amazon pushed a commit that referenced this pull request Sep 3, 2024
@opensearch-trigger-bot @github-actions @toepkerd-zz
changing the names of the alerting comment actions (#724) (#725)
bf6cbd7 
(cherry picked from commit 6a4c248)

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Dennis Toepker <toepkerd@amazon.com>
jowg-amazon pushed a commit that referenced this pull request Sep 3, 2024
@opensearch-trigger-bot @github-actions @toepkerd-zz
changing the names of the alerting comment actions (#724) (#726)
34ba26b 
(cherry picked from commit 6a4c248)

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Dennis Toepker <toepkerd@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eirsep eirsep eirsep approved these changes

@AWSHurneyt AWSHurneyt AWSHurneyt approved these changes

@lezzago lezzago Awaiting requested review from lezzago lezzago is a code owner

@bowenlan-amzn bowenlan-amzn Awaiting requested review from bowenlan-amzn bowenlan-amzn is a code owner

@rishabhmaurya rishabhmaurya Awaiting requested review from rishabhmaurya rishabhmaurya is a code owner

@getsaurabh02 getsaurabh02 Awaiting requested review from getsaurabh02 getsaurabh02 is a code owner

@sbcd90 sbcd90 Awaiting requested review from sbcd90 sbcd90 is a code owner

@engechas engechas Awaiting requested review from engechas engechas is a code owner

@riysaxen-amzn riysaxen-amzn Awaiting requested review from riysaxen-amzn riysaxen-amzn is a code owner

@jowg-amazon jowg-amazon Awaiting requested review from jowg-amazon jowg-amazon is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.15
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants