Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the "Master" nomenclature #319

Closed
6 tasks
Tracked by #2589 ...
tlfeng opened this issue Mar 4, 2022 · 2 comments
Closed
6 tasks
Tracked by #2589 ...

Change the "Master" nomenclature #319

tlfeng opened this issue Mar 4, 2022 · 2 comments
Assignees

Comments

@tlfeng
Copy link

tlfeng commented Mar 4, 2022

Is your feature request related to a problem? Please describe.
OpenSearch repository is going to replace the terminology "master"with "cluster manager".
issue: opensearch-project/OpenSearch#472, with the plan for its terminology replacement.

Although the existing usages with "master" will be supported in OpenSearch version 2.x until further notice to keep the backwards compatibility, it's suggested to prepare for the nomenclature change in advance, and replace all the usages with "master" terminology in the code base.

Describe the solution you'd like
Replace the terminology "master" with "cluster manager".

When being compatible with OpenSearch 2.0:

  • Replace "master" in code comment and internal variable / class name.

When being compatible with OpenSearch 3.0:

  • Replace "master" in the reference to OpenSearch Java API
    (most of the new APIs are available in version 2.2, except AcknowledgedRequest and AcknowledgedResponse)
    • updateSettingsRequest.masterNodeTimeout -> updateSettingsRequest.clusterManagerNodeTimeout
    • openIndexRequest.masterNodeTimeout() -> openIndexRequest.clusterManagerNodeTimeout
    • import org.opensearch.action.support.master.MasterNodeRequest -> import org.opensearch.action.support.clustermanager.ClusterManagerNodeRequest
    • import org.opensearch.action.support.master.TransportMasterNodeAction -> import org.opensearch.action.support.clustermanager.TransportClusterManagerNodeAction
    • import org.opensearch.action.support.master.AcknowledgedRequest -> import org.opensearch.action.support.clustermanager.AcknowledgedRequest (will be available in version 3.0)
    • import org.opensearch.action.support.master.AcknowledgedResponse -> import org.opensearch.action.support.clustermanager.AcknowledgedResponse (will be available in version 3.0)

Describe alternatives you've considered
None.

Additional context

@tlfeng tlfeng added enhancement New feature or request untriaged labels Mar 4, 2022
naveenpajjuri pushed a commit to naveenpajjuri/cross-cluster-replication that referenced this issue Apr 6, 2022
Signed-off-by: Naveen Pajjuri <nppajjur@amazon.com>
naveenpajjuri pushed a commit to naveenpajjuri/cross-cluster-replication that referenced this issue Apr 6, 2022
Signed-off-by: Naveen Pajjuri <nppajjur@amazon.com>
naveenpajjuri pushed a commit that referenced this issue Apr 6, 2022
Signed-off-by: Naveen Pajjuri <nppajjur@amazon.com>
@naveenpajjuri
Copy link
Contributor

Renamed master to Cluster Manager where ever possible in variable, class names and updated the documentation accordingly.

@tlfeng
Copy link
Author

tlfeng commented Sep 16, 2022

After searching the keyword in the repository through GitHub, I found there are several Java APIs still need to be replaced before version 3.0, and I updated in the issue description, please take a look at. Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants