Add basic github workflow for build and test #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soosinha
force-pushed
the
git-wf
branch
2 times, most recently
from
1275a89
to
79fac71
Compare
krishna-ggk
previously approved these changes
Sep 1, 2021
dblock
previously requested changes
Sep 1, 2021
There was a problem hiding this comment.
Switch CI to build a snapshot.
In traditional maven projects you want to be developing snapshot, then when you're ready to make it alpha, beta, rc and release. But in Gradle we parameterize this. So most of the time you want a throw-away build that can't accidentally become release.
dblock
reviewed
Sep 1, 2021
dblock
reviewed
Sep 1, 2021
Merged
1 task
ankitkala
force-pushed
the
git-wf
branch
7 times, most recently
from
23c18f7
to
081fee0
Compare
naveenpajjuri
previously approved these changes
Sep 7, 2021
ankitkala
force-pushed
the
git-wf
branch
2 times, most recently
from
c1c87a2
to
2b40754
Compare
naveenpajjuri
previously approved these changes
Sep 7, 2021
tbhanu-amzn
previously approved these changes
Sep 7, 2021
ankitkala
dismissed stale reviews from tbhanu-amzn and naveenpajjuri
via
957eb7f
ankitkala
force-pushed
the
git-wf
branch
4 times, most recently
from
c2231a7
to
3c230af
Compare
ankitkala
force-pushed
the
git-wf
branch
4 times, most recently
from
1e501b8
to
27bd57a
Compare
saikaranam-amazon
previously approved these changes
Sep 8, 2021
tbhanu-amzn
previously approved these changes
Sep 8, 2021
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
ankitkala
dismissed stale reviews from tbhanu-amzn and saikaranam-amazon
via
6b81e72
Done |
naveenpajjuri
approved these changes
Sep 9, 2021
saikaranam-amazon
approved these changes
Sep 9, 2021
ankitkala
dismissed
dblock’s stale review
I've addressed the changes suggested. Need to push the changes now.
ankitkala
added a commit
that referenced
this pull request
Sep 16, 2021
Signed-off-by: Sooraj Sinha <soosinha@amazon.com> Co-authored-by: Ankit Kala <ankikala@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a github workflow which will build and run integ test on PRs/code pushed to
main.Sample test run : https://github.com/soosinha/cross-cluster-replication/pull/1/checks?check_run_id=3442155037
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.