Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to verify binary install into dashboards #159

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

derek-ho
Copy link
Contributor

@derek-ho derek-ho commented Feb 26, 2024

Description

I have observed some issues within other plugins of issues being only caught at run time. This is because several things can go wrong during the build process, which may not be caught in a dev setup. This adds a workflow to verify that building and installing into OSD works on every PR.

Related issues:
opensearch-project/security-dashboards-plugin#1709
opensearch-project/security-analytics-dashboards-plugin#875
opensearch-project/dashboards-observability#309
opensearch-project/OpenSearch-Dashboards#5952

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test.
  • New functionality has user manual doc added.
  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Derek Ho <dxho@amazon.com>
@derek-ho
Copy link
Contributor Author

Testing to see if this would have caught RC testing issue by reverting PR fix in: 6a480cd

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.95%. Comparing base (80c1e8e) to head (6a480cd).

❗ Current head 6a480cd differs from pull request most recent head e3423c5. Consider uploading reports for the commit e3423c5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #159   +/-   ##
=======================================
  Coverage   89.95%   89.95%           
=======================================
  Files          52       52           
  Lines        1414     1414           
  Branches      337      337           
=======================================
  Hits         1272     1272           
  Misses        140      140           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@derek-ho
Copy link
Contributor Author

Actually not sure if this would have caught it since reading more about the issue it may be a platform specific thing that caused a different version of node to be used. @joshuali925 can you take a look at this PR regardless? I will revert the revert commit if you are in agreement that this wouldn't have caused it (although we can test it by re-running the job after OSD core no longer has issues)

@derek-ho derek-ho added the backport 2.x Trigger the backport flow to 2.x label Feb 26, 2024
Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. i heard those were caused by newer nodejs versions running on older platforms, i don't think ubuntu-latest has the issue. but i think this is good to have

@raintygao
Copy link
Collaborator

@derek-ho Should this change be released in 2.13?

@raintygao raintygao merged commit 8ed80ab into opensearch-project:main Mar 19, 2024
15 of 30 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 19, 2024
Signed-off-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit 8ed80ab)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
raintygao pushed a commit that referenced this pull request Mar 19, 2024
(cherry picked from commit 8ed80ab)

Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Trigger the backport flow to 2.x v2.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants