Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support advanced settings #68

Merged
merged 5 commits into from
Apr 15, 2022
Merged

Conversation

joshuali925
Copy link
Member

Description

closes #43

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
@joshuali925 joshuali925 requested a review from a team as a code owner April 14, 2022 17:16
Signed-off-by: Joshua Li <joshuali925@gmail.com>
This reverts commit df0d249.

Signed-off-by: Joshua Li <joshuali925@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #68 (14017d7) into main (f7ddcb8) will decrease coverage by 0.56%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   95.30%   94.73%   -0.57%     
==========================================
  Files           5        5              
  Lines         149      152       +3     
  Branches       45       45              
==========================================
+ Hits          142      144       +2     
- Misses          7        8       +1     
Impacted Files Coverage Δ
gantt-chart/public/gantt_request_handler.ts 94.44% <75.00%> (-5.56%) ⬇️
gantt-chart/public/components/options_editor.tsx 100.00% <100.00%> (ø)
gantt-chart/public/gantt_vis_type.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7ddcb8...14017d7. Read the comment docs.

@joshuali925 joshuali925 merged commit 3b82489 into opensearch-project:main Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Applies filters when it should not when ignoreFilterIfFieldNotInIndex setting is on
3 participants