Create UploadGeoJSONRequest content as an object #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update request to deserialize content into object. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #32 +/- ##
============================================
+ Coverage 87.09% 88.80% +1.70%
- Complexity 33 44 +11
============================================
Files 9 10 +1
Lines 93 125 +32
Branches 8 12 +4
============================================
+ Hits 81 111 +30
- Misses 12 14 +2
Continue to review full report at Codecov.
|
VijayanB
changed the title
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
force-pushed
the
add-request-content
branch
2 times, most recently
from
79c1a6f
to
d6ac9af
Compare
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
force-pushed
the
add-request-content
branch
2 times, most recently
from
9229cc5
to
d12e392
Compare
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
force-pushed
the
add-request-content
branch
from
d12e392
to
49b1ca9
Compare
src/main/java/org/opensearch/geospatial/action/upload/geojson/UploadGeoJSONRequestContent.java
Outdated
Show resolved
Hide resolved
VijayanB
force-pushed
the
add-request-content
branch
2 times, most recently
from
ace41b3
to
782e7af
Compare
check whether input has valid index name, geospatial field and GeoJSON data. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
force-pushed
the
add-request-content
branch
from
782e7af
to
7e43e65
Compare
1 task
Currently, there are two field types, geo_shape and geo_point. Allow user to pass this information while creating index. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
jmazanec15
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vijayan Balasubramanian balasvij@amazon.com
Description
Create Request content object to deserialize into an object. This will be used by Transport action
to build logic to index request content as document into an index.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.