Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BulkResponse build error message #46

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

VijayanB
Copy link
Member

@VijayanB VijayanB commented Apr 9, 2022

Signed-off-by: Vijayan Balasubramanian balasvij@amazon.com

Description

Remove explicit error message builder method and use
method from BulkResponse.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Remove explicit error message append method and use,
method from BulkResponse.

Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
@VijayanB VijayanB requested a review from a team April 9, 2022 23:26
@VijayanB VijayanB self-assigned this Apr 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2022

Codecov Report

Merging #46 (2c6ce41) into main (2ae58a7) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main      #46      +/-   ##
============================================
- Coverage     88.98%   88.82%   -0.17%     
+ Complexity      103      102       -1     
============================================
  Files            15       15              
  Lines           336      331       -5     
  Branches         27       27              
============================================
- Hits            299      294       -5     
  Misses           33       33              
  Partials          4        4              
Impacted Files Coverage Δ
...rch/geospatial/action/upload/geojson/Uploader.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ae58a7...2c6ce41. Read the comment docs.

@VijayanB VijayanB merged commit b8c1cfc into opensearch-project:main Apr 11, 2022
@VijayanB VijayanB deleted the error-message branch April 11, 2022 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants