Fix for snapshot tests race condition #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prabhat Sharma <ptsharma@amazon.com>
CaptainDredge
requested review from
amsiglan,
AWSHurneyt,
bowenlan-amzn,
getsaurabh02,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
lezzago,
sbcd90,
eirsep,
r1walz and
vikasvb90
as code owners
SuZhou-Joe
approved these changes
Aug 16, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 16, 2024
Signed-off-by: Prabhat Sharma <ptsharma@amazon.com> Co-authored-by: Prabhat Sharma <ptsharma@amazon.com> (cherry picked from commit 883da5a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
astute-decipher
pushed a commit
to astute-decipher/index-management-dashboards-plugin
that referenced
this pull request
Aug 16, 2024
Signed-off-by: Prabhat Sharma <ptsharma@amazon.com> Co-authored-by: Prabhat Sharma <ptsharma@amazon.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 17, 2024
* Initial commit for header update for snapshot management policy page Signed-off-by: Shubh Sahu <shubhvs@amazon.com> * some correction Signed-off-by: Shubh Sahu <shubhvs@amazon.com> * final commit Signed-off-by: Shubh Sahu <shubhvs@amazon.com> * Update pages snapshots (#1111) Signed-off-by: Sandeep Kumawat <skumwt@amazon.com> Co-authored-by: Sandeep Kumawat <skumwt@amazon.com> * Fix for snapshot test race condition (#1113) Signed-off-by: Prabhat Sharma <ptsharma@amazon.com> Co-authored-by: Prabhat Sharma <ptsharma@amazon.com> * Few refactoring Signed-off-by: Shubh Sahu <shubhvs@amazon.com> * resolving UT build failures Signed-off-by: Shubh Sahu <shubhvs@amazon.com> --------- Signed-off-by: Shubh Sahu <shubhvs@amazon.com> Signed-off-by: Sandeep Kumawat <skumwt@amazon.com> Signed-off-by: Prabhat Sharma <ptsharma@amazon.com> Co-authored-by: Shubh Sahu <shubhvs@amazon.com> Co-authored-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com> Co-authored-by: Sandeep Kumawat <skumwt@amazon.com> Co-authored-by: Prabhat <20185657+CaptainDredge@users.noreply.github.com> Co-authored-by: Prabhat Sharma <ptsharma@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 17, 2024
* Initial commit for header update for snapshot management policy page Signed-off-by: Shubh Sahu <shubhvs@amazon.com> * some correction Signed-off-by: Shubh Sahu <shubhvs@amazon.com> * final commit Signed-off-by: Shubh Sahu <shubhvs@amazon.com> * Update pages snapshots (#1111) Signed-off-by: Sandeep Kumawat <skumwt@amazon.com> Co-authored-by: Sandeep Kumawat <skumwt@amazon.com> * Fix for snapshot test race condition (#1113) Signed-off-by: Prabhat Sharma <ptsharma@amazon.com> Co-authored-by: Prabhat Sharma <ptsharma@amazon.com> * Few refactoring Signed-off-by: Shubh Sahu <shubhvs@amazon.com> * resolving UT build failures Signed-off-by: Shubh Sahu <shubhvs@amazon.com> --------- Signed-off-by: Shubh Sahu <shubhvs@amazon.com> Signed-off-by: Sandeep Kumawat <skumwt@amazon.com> Signed-off-by: Prabhat Sharma <ptsharma@amazon.com> Co-authored-by: Shubh Sahu <shubhvs@amazon.com> Co-authored-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com> Co-authored-by: Sandeep Kumawat <skumwt@amazon.com> Co-authored-by: Prabhat <20185657+CaptainDredge@users.noreply.github.com> Co-authored-by: Prabhat Sharma <ptsharma@amazon.com> (cherry picked from commit 12f28d1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
astute-decipher
added a commit
to astute-decipher/index-management-dashboards-plugin
that referenced
this pull request
Aug 17, 2024
…ect#1108) * Initial commit for header update for snapshot management policy page Signed-off-by: Shubh Sahu <shubhvs@amazon.com> * some correction Signed-off-by: Shubh Sahu <shubhvs@amazon.com> * final commit Signed-off-by: Shubh Sahu <shubhvs@amazon.com> * Update pages snapshots (opensearch-project#1111) Signed-off-by: Sandeep Kumawat <skumwt@amazon.com> Co-authored-by: Sandeep Kumawat <skumwt@amazon.com> * Fix for snapshot test race condition (opensearch-project#1113) Signed-off-by: Prabhat Sharma <ptsharma@amazon.com> Co-authored-by: Prabhat Sharma <ptsharma@amazon.com> * Few refactoring Signed-off-by: Shubh Sahu <shubhvs@amazon.com> * resolving UT build failures Signed-off-by: Shubh Sahu <shubhvs@amazon.com> --------- Signed-off-by: Shubh Sahu <shubhvs@amazon.com> Signed-off-by: Sandeep Kumawat <skumwt@amazon.com> Signed-off-by: Prabhat Sharma <ptsharma@amazon.com> Co-authored-by: Shubh Sahu <shubhvs@amazon.com> Co-authored-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com> Co-authored-by: Sandeep Kumawat <skumwt@amazon.com> Co-authored-by: Prabhat <20185657+CaptainDredge@users.noreply.github.com> Co-authored-by: Prabhat Sharma <ptsharma@amazon.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 19, 2024
(cherry picked from commit 883da5a) Signed-off-by: Prabhat Sharma <ptsharma@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Prabhat Sharma <ptsharma@amazon.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 19, 2024
* Initial commit for header update for snapshot management policy page Signed-off-by: Shubh Sahu <shubhvs@amazon.com> * some correction Signed-off-by: Shubh Sahu <shubhvs@amazon.com> * final commit Signed-off-by: Shubh Sahu <shubhvs@amazon.com> * Update pages snapshots (#1111) Signed-off-by: Sandeep Kumawat <skumwt@amazon.com> Co-authored-by: Sandeep Kumawat <skumwt@amazon.com> * Fix for snapshot test race condition (#1113) Signed-off-by: Prabhat Sharma <ptsharma@amazon.com> Co-authored-by: Prabhat Sharma <ptsharma@amazon.com> * Few refactoring Signed-off-by: Shubh Sahu <shubhvs@amazon.com> * resolving UT build failures Signed-off-by: Shubh Sahu <shubhvs@amazon.com> --------- Signed-off-by: Shubh Sahu <shubhvs@amazon.com> Signed-off-by: Sandeep Kumawat <skumwt@amazon.com> Signed-off-by: Prabhat Sharma <ptsharma@amazon.com> Co-authored-by: Shubh Sahu <shubhvs@amazon.com> Co-authored-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com> Co-authored-by: Sandeep Kumawat <skumwt@amazon.com> Co-authored-by: Prabhat <20185657+CaptainDredge@users.noreply.github.com> Co-authored-by: Prabhat Sharma <ptsharma@amazon.com> (cherry picked from commit 12f28d1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 19, 2024
* Initial commit for header update for snapshot management policy page * some correction * final commit * Update pages snapshots (#1111) * Fix for snapshot test race condition (#1113) * Few refactoring * resolving UT build failures --------- (cherry picked from commit 12f28d1) Signed-off-by: Shubh Sahu <shubhvs@amazon.com> Signed-off-by: Sandeep Kumawat <skumwt@amazon.com> Signed-off-by: Prabhat Sharma <ptsharma@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Shubh Sahu <shubhvs@amazon.com> Co-authored-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com> Co-authored-by: Sandeep Kumawat <skumwt@amazon.com> Co-authored-by: Prabhat <20185657+CaptainDredge@users.noreply.github.com> Co-authored-by: Prabhat Sharma <ptsharma@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds fix for
AssociatedComponentsModalsnapshot test failureIssues Resolved
NA
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.