Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add refresh button to rollup page #132

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

annie3431
Copy link
Contributor

Signed-off-by: Annie Lee leeyun@amazon.com

Description

Adding a refresh button to rollup landing page

Issues Resolved

N/A

Screenshot

image

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2021

Codecov Report

Merging #132 (5163547) into main (8099d0c) will not change coverage.
The diff coverage is n/a.

❗ Current head 5163547 differs from pull request most recent head 55d1c26. Consider uploading reports for the commit 55d1c26 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage   63.34%   63.34%           
=======================================
  Files         155      155           
  Lines        4411     4411           
  Branches      731      731           
=======================================
  Hits         2794     2794           
  Misses       1405     1405           
  Partials      212      212           
Impacted Files Coverage Δ
...ublic/pages/Rollups/containers/Rollups/Rollups.tsx 69.35% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8099d0c...55d1c26. Read the comment docs.

Signed-off-by: Annie Lee <leeyun@amazon.com>
Copy link
Member

@bowenlan-amzn bowenlan-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@annie3431 annie3431 merged commit fed8b29 into opensearch-project:main Nov 17, 2021
@annie3431 annie3431 deleted the rollup-refresh branch November 17, 2021 19:01
annie3431 added a commit to annie3431/index-management-dashboards-plugin that referenced this pull request Feb 17, 2022
Signed-off-by: Annie Lee <leeyun@amazon.com>
annie3431 added a commit to annie3431/index-management-dashboards-plugin that referenced this pull request Feb 17, 2022
Signed-off-by: Annie Lee <leeyun@amazon.com>
bowenlan-amzn pushed a commit that referenced this pull request Mar 4, 2022
Signed-off-by: Annie Lee <leeyun@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants