Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix exports is undefined #841

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport be25b8b from #826.

* Add allowTopLevelThis=true option for @babel/plugin-transform-modules-commonjs

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* remove override babel.config.js for build

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
(cherry picked from commit be25b8b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added autocut v2.10.0 Issues targeting release v2.10.0 labels Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #841 (ab954b8) into 2.x (eeffd64) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.x     #841   +/-   ##
=======================================
  Coverage   63.36%   63.36%           
=======================================
  Files         341      341           
  Lines       11553    11553           
  Branches     2112     2112           
=======================================
  Hits         7321     7321           
  Misses       3658     3658           
  Partials      574      574           

@Hailong-am Hailong-am merged commit 639df0d into 2.x Aug 11, 2023
12 of 13 checks passed
@github-actions github-actions bot deleted the backport/backport-826-to-2.x branch August 11, 2023 05:45
@Hailong-am
Copy link
Collaborator

test the build artifact for 2.x branch, no export is undefined issue.

opensearch-trigger-bot bot added a commit that referenced this pull request Aug 25, 2023
* Add allowTopLevelThis=true option for @babel/plugin-transform-modules-commonjs

* remove override babel.config.js for build

---------

(cherry picked from commit be25b8b)

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 639df0d)
bowenlan-amzn added a commit that referenced this pull request Sep 22, 2023
* Add allowTopLevelThis=true option for @babel/plugin-transform-modules-commonjs

* remove override babel.config.js for build

---------

(cherry picked from commit be25b8b)

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 639df0d)

Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut backport 2.9 v2.10.0 Issues targeting release v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants