Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected typo on 'Minimum' textbox label on snapshot policy page --s… #962

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

coultonluke
Copy link
Contributor

@coultonluke coultonluke commented Jan 10, 2024

…ign-off

Description

Corrected typo on 'Minimum' textbox label on snapshot policy page. Currently reads 'Minumum'.

Issues Resolved

n/a

Check List

  • [Y] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (64e8c25) 63.37% compared to head (4769ef2) 63.37%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #962   +/-   ##
=======================================
  Coverage   63.37%   63.37%           
=======================================
  Files         341      341           
  Lines       11554    11554           
  Branches     2112     2112           
=======================================
  Hits         7322     7322           
  Misses       3658     3658           
  Partials      574      574           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ign-off

Signed-off-by: coultonluke <luke@luke.org.uk>
@r1walz
Copy link
Contributor

r1walz commented Feb 12, 2024

Hi, @coultonluke. Thanks for this contribution. Might you also address typos for finalized (in fininalized) and retention (in rententionEnableRadios)?

@coultonluke
Copy link
Contributor Author

@r1walz Given that those typos are just in the code and not visible to users, I wouldn't be too bothered about it.

Copy link
Contributor

@r1walz r1walz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. Ty.

@r1walz r1walz merged commit d8d3bd7 into opensearch-project:main Feb 13, 2024
12 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 13, 2024
…ign-off (#962)

Signed-off-by: coultonluke <luke@luke.org.uk>
(cherry picked from commit d8d3bd7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
r1walz pushed a commit that referenced this pull request Feb 13, 2024
…ign-off (#962) (#977)

(cherry picked from commit d8d3bd7)

Signed-off-by: coultonluke <luke@luke.org.uk>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 15, 2024
…ign-off (#962)

Signed-off-by: coultonluke <luke@luke.org.uk>
(cherry picked from commit d8d3bd7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants