Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to verify binary installation into dashboards core #999

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

derek-ho
Copy link
Contributor

@derek-ho derek-ho commented Feb 26, 2024

Description

I have observed some issues within other plugins of issues being only caught at run time. This is because several things can go wrong during the build process, which may not be caught in a dev setup. This adds a workflow to verify that building and installing into OSD works on every PR.

Related issues:
opensearch-project/security-dashboards-plugin#1709
opensearch-project/security-analytics-dashboards-plugin#875
opensearch-project/dashboards-observability#309

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.37%. Comparing base (2128bf2) to head (74b68c4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #999   +/-   ##
=======================================
  Coverage   63.37%   63.37%           
=======================================
  Files         341      341           
  Lines       11554    11554           
  Branches     2243     2243           
=======================================
  Hits         7322     7322           
  Misses       3658     3658           
  Partials      574      574           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@derek-ho
Copy link
Contributor Author

derek-ho commented Feb 26, 2024

@SuZhou-Joe @xluo-aws it seems like there is an issue that this workflow caught in main, can you check if this is expected or not:

{"type":"log","@timestamp":"2024-02-26T15:44:26Z","tags":["fatal","root"],"pid":4346,"message":"Error: Cannot find module './authentication_methods_registry.mock'\nRequire stack:\n- /home/runner/work/index-management-dashboards-plugin/index-management-dashboards-plugin/opensearch-dashboards-3.0.0-linux-x64/src/plugins/data_source/server/auth_registry/index.js\n- /home/runner/work/index-management-dashboards-plugin/index-management-dashboards-plugin/opensearch-dashboards-3.0.0-linux-x64/src/plugins/data_source/server/plugin.js\n- /home/runner/work/index-management-dashboards-plugin/index-management-dashboards-plugin/opensearch-dashboards-3.0.0-linux-x64/src/plugins/data_source/server/index.js\n- /home/runner/work/index-management-dashboards-plugin/index-management-dashboards-plugin/opensearch-dashboards-3.0.0-linux-x64/src/core/server/plugins/plugin.js\n- /home/runner/work/index-management-dashboards-plugin/index-management-dashboards-plugin/opensearch-dashboards-3.0.0-linux-x64/src/core/server/plugins/discovery/plugins_discovery.js\n- /home/runner/work/index-management-dashboards-plugin/index-management-dashboards-plugin/opensearch-dashboards-3.0.0-linux-x64/src/core/server/plugins/discovery/index.js\n- /home/runner/work/index-management-dashboards-plugin/index-management-dashboards-plugin/opensearch-dashboards-3.0.0-linux-x64/src/core/server/plugins/plugins_service.js\n- /home/runner/work/index-management-dashboards-plugin/index-management-dashboards-plugin/opensearch-dashboards-3.0.0-linux-x64/src/core/server/plugins/index.js\n- /home/runner/work/index-management-dashboards-plugin/index-management-dashboards-plugin/opensearch-dashboards-3.0.0-linux-x64/src/core/server/index.js\n- /home/runner/work/index-management-dashboards-plugin/index-management-dashboards-plugin/opensearch-dashboards-3.0.0-linux-x64/src/cli/serve/serve.js\n- /home/runner/work/index-management-dashboards-plugin/index-management-dashboards-plugin/opensearch-dashboards-3.0.0-linux-x64/src/cli/cli.js\n- /home/runner/work/index-management-dashboards-plugin/index-management-dashboards-plugin/opensearch-dashboards-3.0.0-linux-x64/src/cli/dist.js\n at Function.Module._resolveFilename (node:internal/modules/cjs/loader:1134:15)\n at Module.Hook._require.Module.require (/home/runner/work/index-management-dashboards-plugin/index-management-dashboards-plugin/opensearch-dashboards-3.0.0-linux-x64/node_modules/require-in-the-middle/index.js:61:29)\n at require (node:internal/modules/helpers:177:18)\n at Object.<anonymous> (/home/runner/work/index-management-dashboards-plugin/index-management-dashboards-plugin/opensearch-dashboards-3.0.0-linux-x64/src/plugins/data_source/server/auth_registry/index.js:25:41)\n at Module._compile (node:internal/modules/cjs/loader:1356:14)\n at Object.Module._extensions..js (node:internal/modules/cjs/loader:1414:10)\n at Module.load (node:internal/modules/cjs/loader:1197:32)\n at Function.Module._load (node:internal/modules/cjs/loader:1013:12)\n at Module.require (node:internal/modules/cjs/loader:1225:19)\n at Module.Hook._require.Module.require (/home/runner/work/index-management-dashboards-plugin/index-management-dashboards-plugin/opensearch-dashboards-3.0.0-linux-x64/node_modules/require-in-the-middle/index.js:80:39) {\n code: 'MODULE_NOT_FOUND',\n requireStack: [\n '/home/runner/work/index-management-dashboards-plugin/index-management-dashboards-plugin/opensearch-dashboards-3.0.0-linux-x64/src/plugins/data_source/server/auth_registry/index.js',\n '/home/runner/work/index-management-dashboards-plugin/index-management-dashboards-plugin/opensearch-dashboards-3.0.0-linux-x64/src/plugins/data_source/server/plugin.js',\n '/home/runner/work/index-management-dashboards-plugin/index-management-dashboards-plugin/opensearch-dashboards-3.0.0-linux-x64/src/plugins/data_source/server/index.js',\n '/home/runner/work/index-management-dashboards-plugin/index-management-dashboards-plugin/opensearch-dashboards-3.0.0-linux-x64/src/core/server/plugins/plugin.js',\n '/home/runner/work/index-management-dashboards-plugin/index-management-dashboards-plugin/opensearch-dashboards-3.0.0-linux-x64/src/core/server/plugins/discovery/plugins_discovery.js',\n '/home/runner/work/index-management-dashboards-plugin/index-management-dashboards-plugin/opensearch-dashboards-3.0.0-linux-x64/src/core/server/plugins/discovery/index.js',\n '/home/runner/work/index-management-dashboards-plugin/index-management-dashboards-plugin/opensearch-dashboards-3.0.0-linux-x64/src/core/server/plugins/plugins_service.js',\n '/home/runner/work/index-management-dashboards-plugin/index-management-dashboards-plugin/opensearch-dashboards-3.0.0-linux-x64/src/core/server/plugins/index.js',\n '/home/runner/work/index-management-dashboards-plugin/index-management-dashboards-plugin/opensearch-dashboards-3.0.0-linux-x64/src/core/server/index.js',\n '/home/runner/work/index-management-dashboards-plugin/index-management-dashboards-plugin/opensearch-dashboards-3.0.0-linux-x64/src/cli/serve/serve.js',\n '/home/runner/work/index-management-dashboards-plugin/index-management-dashboards-plugin/opensearch-dashboards-3.0.0-linux-x64/src/cli/cli.js',\n '/home/runner/work/index-management-dashboards-plugin/index-management-dashboards-plugin/opensearch-dashboards-3.0.0-linux-x64/src/cli/dist.js'\n ]\n}"}

@derek-ho
Copy link
Contributor Author

Potentially coming from core actually

@derek-ho
Copy link
Contributor Author

Created an issue in OSD and asked for follow up: opensearch-project/OpenSearch-Dashboards#5952

Copy link
Member

@SuZhou-Joe SuZhou-Joe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SuZhou-Joe SuZhou-Joe merged commit d516380 into opensearch-project:main Mar 22, 2024
11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 22, 2024
Signed-off-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit d516380)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Aug 21, 2024
Signed-off-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit d516380)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants