1. Porting additional check in rollover step that is missing in githu…

…b 2. Minor optimization, converting to set 3. Updating schema version

Signed-off-by: Ravi Thaluru <thalurur@users.noreply.github.com>

src/main/kotlin/org/opensearch/indexmanagement/indexstatemanagement/ManagedIndexCoordinator.kt

@@ -297,7 +297,7 @@ class ManagedIndexCoordinator(
             val deletedIndices = event.indicesDeleted().map { it.name }
             val allIndicesUuid = indexMetadataProvider.getMultiTypeISMIndexMetadata(indexNames = deletedIndices).map { (_, metadataMapForType) ->
                 metadataMapForType.values.map { it.indexUuid }
-            }.flatten()
+            }.flatten().toSet()
             // Check if the deleted index uuid is still part of any metadata service in the cluster and has an existing managed index job
             indicesToClean = event.indicesDeleted().filter { it.uuid in managedIndices.keys && !allIndicesUuid.contains(it.uuid) }
             removeManagedIndexReq = indicesToClean.map { deleteManagedIndexRequest(it.uuid) }

src/main/kotlin/org/opensearch/indexmanagement/indexstatemanagement/step/rollover/AttemptRolloverStep.kt

@@ -46,6 +46,14 @@ class AttemptRolloverStep(private val action: RolloverAction) : Step(name) {
             return this
         }
 
+        // If we have already rolled over this index then fail as we only allow an index to be rolled over once
+        if (context.metadata.rolledOver == true) {
+            logger.warn("$indexName was already rolled over, cannot execute rollover step")
+            stepStatus = StepStatus.FAILED
+            info = mapOf("message" to getFailedDuplicateRolloverMessage(indexName))
+            return this
+        }
+
         val (rolloverTarget, isDataStream) = getRolloverTargetOrUpdateInfo(context)
         // If the rolloverTarget is null, we would've already updated the failed info from getRolloverTargetOrUpdateInfo and can return early
         rolloverTarget ?: return this

src/main/resources/mappings/opendistro-ism-config.json

@@ -1,6 +1,6 @@
 {
   "_meta" : {
-    "schema_version": 14
+    "schema_version": 15
   },
   "dynamic": "strict",
   "properties": {

src/test/kotlin/org/opensearch/indexmanagement/IndexManagementRestTestCase.kt

@@ -27,7 +27,7 @@ import javax.management.remote.JMXServiceURL
 
 abstract class IndexManagementRestTestCase : ODFERestTestCase() {
 
-    val configSchemaVersion = 14
+    val configSchemaVersion = 15
     val historySchemaVersion = 5
 
     // Having issues with tests leaking into other tests and mappings being incorrect and they are not caught by any pending task wait check as

src/test/resources/mappings/cached-opendistro-ism-config.json

@@ -1,6 +1,6 @@
 {
   "_meta" : {
-    "schema_version": 14
+    "schema_version": 15
   },
   "dynamic": "strict",
   "properties": {