Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes rc1 qualifier #353

Merged
merged 2 commits into from
May 12, 2022
Merged

Conversation

downsrob
Copy link
Contributor

@downsrob downsrob commented May 5, 2022

Signed-off-by: Clay Downs downsrob@amazon.com

Issue #, if available:
#351

Description of changes:
Removes rc1 qualifier as we move from the 2.0 rc1 release to the 2.0 GA release
CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Clay Downs <downsrob@amazon.com>
@downsrob downsrob marked this pull request as ready for review May 5, 2022 16:19
@downsrob downsrob requested a review from a team May 5, 2022 16:19
Signed-off-by: Clay Downs <downsrob@amazon.com>
@downsrob
Copy link
Contributor Author

CI failed due to:

org.opensearch.indexmanagement.indexstatemanagement.model.ActionTests > test shrink disk threshold percentage settings FAILED
Suite: Test class org.opensearch.indexmanagement.indexstatemanagement.model.ActionTests
    java.lang.AssertionError: Free bytes threshold not being calculated correctly for percentage setting. expected:<249108103167> but was:<249108103168>
  2> REPRODUCE WITH: gradlew ':test' --tests "org.opensearch.indexmanagement.indexstatemanagement.model.ActionTests.test shrink disk threshold percentage settings" -Dtests.seed=5FF9F3D9E84884CD -Dtests.security.manager=false -Dtests.locale=ar-YE -Dtests.timezone=Africa/Blantyre -Druntime.java=17
        at __randomizedtesting.SeedInfo.seed([5FF9F3D9E84884CD:70E4DCFDAD5975D9]:0)
  2> java.lang.AssertionError: Free bytes threshold not being calculated correctly for percentage setting. expected:<249108103167> but was:<249108103168>

Looks like there was a flaky failure in one of the unit tests for shrink due to a rounding error, I added an error of 1 so it doesn't fail in the future.

@downsrob downsrob merged commit 5df46d5 into opensearch-project:main May 12, 2022
@downsrob downsrob deleted the remove-qualifier branch May 12, 2022 19:14
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 12, 2022
* Removes rc1 qualifier

Signed-off-by: Clay Downs <downsrob@amazon.com>

* Allows error in shrink test

Signed-off-by: Clay Downs <downsrob@amazon.com>
(cherry picked from commit 5df46d5)
downsrob added a commit that referenced this pull request May 12, 2022
* Removes rc1 qualifier

Signed-off-by: Clay Downs <downsrob@amazon.com>

* Allows error in shrink test

Signed-off-by: Clay Downs <downsrob@amazon.com>
(cherry picked from commit 5df46d5)

Co-authored-by: Clay Downs <downsrob@amazon.com>
bowenlan-amzn pushed a commit to bowenlan-amzn/index-management that referenced this pull request May 16, 2022
* Removes rc1 qualifier

Signed-off-by: Clay Downs <downsrob@amazon.com>

* Allows error in shrink test

Signed-off-by: Clay Downs <downsrob@amazon.com>
bowenlan-amzn added a commit that referenced this pull request May 17, 2022
* Strengthen scroll search in Coordinator (#356)

* Removes rc1 qualifier (#353)

* Allows error in shrink test

* Adds workflow to create documentation issues (#358)

* Adds documentation issue workflow

* Makes the issue template more relevant

* Data model and Basic CRUD APIs

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
wuychn pushed a commit to ochprince/index-management that referenced this pull request Mar 16, 2023
* Removes rc1 qualifier

Signed-off-by: Clay Downs <downsrob@amazon.com>

* Allows error in shrink test

Signed-off-by: Clay Downs <downsrob@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants