Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for searching multiple rollup indices with same mapping #440

Merged
merged 5 commits into from
Aug 5, 2022

Conversation

petardz
Copy link
Contributor

@petardz petardz commented Aug 2, 2022

Signed-off-by: Petar Dzepina petar.dzepina@gmail.com

Issue #, if available: 321

Description of changes:

Allowed searching multiple rollup indices with matching field mappings from query

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz petardz requested a review from a team August 2, 2022 11:31
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2022

Codecov Report

Merging #440 (00d2f75) into main (b586ec8) will decrease coverage by 0.04%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##               main     #440      +/-   ##
============================================
- Coverage     75.84%   75.80%   -0.05%     
- Complexity     2465     2467       +2     
============================================
  Files           313      313              
  Lines         14426    14411      -15     
  Branches       2230     2228       -2     
============================================
- Hits          10942    10924      -18     
- Misses         2240     2245       +5     
+ Partials       1244     1242       -2     
Impacted Files Coverage Δ
...management/rollup/interceptor/RollupInterceptor.kt 76.19% <75.00%> (+3.17%) ⬆️
...statemanagement/model/destination/CustomWebhook.kt 67.14% <0.00%> (-28.58%) ⬇️
...arch/indexmanagement/rollup/RollupSearchService.kt 61.11% <0.00%> (-3.71%) ⬇️
.../rollup/action/start/TransportStartRollupAction.kt 72.94% <0.00%> (-2.36%) ⬇️
...ent/indexstatemanagement/util/ManagedIndexUtils.kt 76.10% <0.00%> (-1.77%) ⬇️
...nt/indexstatemanagement/ManagedIndexCoordinator.kt 69.29% <0.00%> (+0.58%) ⬆️
.../action/explain/TransportExplainTransformAction.kt 73.03% <0.00%> (+2.24%) ⬆️
...transport/action/explain/TransportExplainAction.kt 72.34% <0.00%> (+5.34%) ⬆️
...ensearch/indexmanagement/util/JobSchedulerUtils.kt 82.60% <0.00%> (+8.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@downsrob downsrob added the v2.2.0 label Aug 5, 2022
…b; Added picking rollup job deterministic

Signed-off-by: petar.dzepina <petar.dzepina@dev22.rs>
Signed-off-by: petar.dzepina <petar.dzepina@dev22.rs>
@downsrob downsrob merged commit b8a77d4 into opensearch-project:main Aug 5, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 5, 2022
…#440)

* added support for searching multiple rollup indices with same mapping

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* fixed failing rollupInterceptorIT  test

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* reverted old error messages

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* reverted checking for matching jobs on whole set instead of job by job; Added picking rollup job deterministic

Signed-off-by: petar.dzepina <petar.dzepina@dev22.rs>

* fixed sorting

Signed-off-by: petar.dzepina <petar.dzepina@dev22.rs>

Co-authored-by: petar.dzepina <petar.dzepina@dev22.rs>
(cherry picked from commit b8a77d4)
downsrob pushed a commit that referenced this pull request Aug 5, 2022
…#440) (#447)

* added support for searching multiple rollup indices with same mapping

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* fixed failing rollupInterceptorIT  test

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* reverted old error messages

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* reverted checking for matching jobs on whole set instead of job by job; Added picking rollup job deterministic

Signed-off-by: petar.dzepina <petar.dzepina@dev22.rs>

* fixed sorting

Signed-off-by: petar.dzepina <petar.dzepina@dev22.rs>

Co-authored-by: petar.dzepina <petar.dzepina@dev22.rs>
(cherry picked from commit b8a77d4)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
@downsrob downsrob mentioned this pull request Aug 6, 2022
6 tasks
petardz added a commit to petardz/index-management that referenced this pull request Aug 9, 2022
…opensearch-project#440)

* added support for searching multiple rollup indices with same mapping

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* fixed failing rollupInterceptorIT  test

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* reverted old error messages

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* reverted checking for matching jobs on whole set instead of job by job; Added picking rollup job deterministic

Signed-off-by: petar.dzepina <petar.dzepina@dev22.rs>

* fixed sorting

Signed-off-by: petar.dzepina <petar.dzepina@dev22.rs>

Co-authored-by: petar.dzepina <petar.dzepina@dev22.rs>
@Angie-Zhang Angie-Zhang mentioned this pull request Sep 9, 2022
1 task
Angie-Zhang pushed a commit to Angie-Zhang/index-management that referenced this pull request Sep 12, 2022
…opensearch-project#440) (opensearch-project#447)

* added support for searching multiple rollup indices with same mapping

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* fixed failing rollupInterceptorIT  test

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* reverted old error messages

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* reverted checking for matching jobs on whole set instead of job by job; Added picking rollup job deterministic

Signed-off-by: petar.dzepina <petar.dzepina@dev22.rs>

* fixed sorting

Signed-off-by: petar.dzepina <petar.dzepina@dev22.rs>

Co-authored-by: petar.dzepina <petar.dzepina@dev22.rs>
(cherry picked from commit b8a77d4)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Angie Zhang <langelzh@amazon.com>
wuychn pushed a commit to ochprince/index-management that referenced this pull request Mar 16, 2023
…opensearch-project#440) (opensearch-project#447)

* added support for searching multiple rollup indices with same mapping

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* fixed failing rollupInterceptorIT  test

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* reverted old error messages

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* reverted checking for matching jobs on whole set instead of job by job; Added picking rollup job deterministic

Signed-off-by: petar.dzepina <petar.dzepina@dev22.rs>

* fixed sorting

Signed-off-by: petar.dzepina <petar.dzepina@dev22.rs>

Co-authored-by: petar.dzepina <petar.dzepina@dev22.rs>
(cherry picked from commit b8a77d4)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
ronnaksaxena pushed a commit to ronnaksaxena/index-management that referenced this pull request Jul 19, 2023
…opensearch-project#440) (opensearch-project#447)

* added support for searching multiple rollup indices with same mapping

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* fixed failing rollupInterceptorIT  test

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* reverted old error messages

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* reverted checking for matching jobs on whole set instead of job by job; Added picking rollup job deterministic

Signed-off-by: petar.dzepina <petar.dzepina@dev22.rs>

* fixed sorting

Signed-off-by: petar.dzepina <petar.dzepina@dev22.rs>

Co-authored-by: petar.dzepina <petar.dzepina@dev22.rs>
(cherry picked from commit b8a77d4)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Ronnak Saxena <ronsax@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants