Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Replica Count Validation when awareness replica balance is enabled #463

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport f64c0c7 from #429

)

* bump version to 2.2 (#446)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* Replica Count validation when awareness replica balance is enabled

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>

* Addressing PR comments

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit f64c0c7)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team August 12, 2022 18:07
@codecov-commenter
Copy link

Codecov Report

Merging #463 (f64c0c7) into 2.x (4811922) will decrease coverage by 0.03%.
The diff coverage is 67.59%.

❗ Current head f64c0c7 differs from pull request most recent head 235aa4c. Consider uploading reports for the commit 235aa4c to get more accurate results

@@             Coverage Diff              @@
##                2.x     #463      +/-   ##
============================================
- Coverage     75.96%   75.93%   -0.04%     
+ Complexity     2475     2469       -6     
============================================
  Files           314      314              
  Lines         14440    14454      +14     
  Branches       2233     2235       +2     
============================================
+ Hits          10969    10975       +6     
- Misses         2224     2226       +2     
- Partials       1247     1253       +6     
Impacted Files Coverage Δ
...transport/action/explain/TransportExplainAction.kt 72.34% <0.00%> (ø)
.../opensearch/indexmanagement/rollup/model/Rollup.kt 86.04% <ø> (ø)
.../rollup/action/index/TransportIndexRollupAction.kt 71.26% <50.00%> (ø)
...nagement/step/rollup/AttemptCreateRollupJobStep.kt 48.38% <66.66%> (ø)
...arch/indexmanagement/rollup/RollupMapperService.kt 56.34% <76.47%> (ø)
...t/action/indexpolicy/TransportIndexPolicyAction.kt 80.32% <78.94%> (-0.23%) ⬇️
...xmanagement/indexstatemanagement/util/StepUtils.kt 87.64% <85.71%> (ø)
.../rollup/util/RollupFieldValueExpressionResolver.kt 90.00% <90.00%> (ø)
...management/rollup/interceptor/RollupInterceptor.kt 79.36% <92.30%> (+3.17%) ⬆️
...pensearch/indexmanagement/IndexManagementPlugin.kt 89.88% <100.00%> (ø)
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bowenlan-amzn bowenlan-amzn merged commit 729ca33 into 2.x Aug 16, 2022
@github-actions github-actions bot deleted the backport/backport-429-to-2.x branch August 17, 2022 00:12
Angie-Zhang pushed a commit to Angie-Zhang/index-management that referenced this pull request Sep 12, 2022
…pensearch-project#429) (opensearch-project#463)

* bump version to 2.2 (opensearch-project#446)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* Replica Count validation when awareness replica balance is enabled

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>

* Addressing PR comments

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit f64c0c7)

Co-authored-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
Signed-off-by: Angie Zhang <langelzh@amazon.com>
wuychn pushed a commit to ochprince/index-management that referenced this pull request Mar 16, 2023
…pensearch-project#429) (opensearch-project#463)

* bump version to 2.2 (opensearch-project#446)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* Replica Count validation when awareness replica balance is enabled

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>

* Addressing PR comments

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit f64c0c7)

Co-authored-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
ronnaksaxena pushed a commit to ronnaksaxena/index-management that referenced this pull request Jul 19, 2023
…pensearch-project#429) (opensearch-project#463)

* bump version to 2.2 (opensearch-project#446)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* Replica Count validation when awareness replica balance is enabled

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>

* Addressing PR comments

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit f64c0c7)

Co-authored-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
Signed-off-by: Ronnak Saxena <ronsax@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants