Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding signoff option for version workflow PR #156

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

VachaShah
Copy link
Contributor

Signed-off-by: Vacha Shah vachshah@amazon.com

Description

Adding signoff option to pull request action. Coming from opensearch-project/opensearch-build#1375 (comment)

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Vacha Shah <vachshah@amazon.com>
@VachaShah VachaShah requested review from a team and dblock March 23, 2022 18:11
@dblock dblock merged commit 6189414 into opensearch-project:main Mar 23, 2022
@VachaShah VachaShah deleted the dco-version branch March 30, 2022 22:14
@opensearch-trigger-bot
Copy link

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-156-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6189414d24eeeb2c60e658ac7147305cf14dac6f
# Push it to GitHub
git push --set-upstream origin backport/backport-156-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-156-to-1.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 30, 2022
Signed-off-by: Vacha Shah <vachshah@amazon.com>
(cherry picked from commit 6189414)
gaiksaya pushed a commit that referenced this pull request Mar 30, 2022
Signed-off-by: Vacha Shah <vachshah@amazon.com>
(cherry picked from commit 6189414)

Co-authored-by: Vacha Shah <vachshah@amazon.com>
wuychn pushed a commit to ochprince/job-scheduler that referenced this pull request Mar 16, 2023
Signed-off-by: Vacha Shah <vachshah@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants