Adjust lombok annotations, fix variable names

Signed-off-by: Martin Gaievski <gaievski@amazon.com>
opensearch-project · Jul 12, 2022 · 5487268 · 5487268
1 parent 053bd6e
commit 5487268
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 9 deletions.
diff --git a/src/main/java/org/opensearch/knn/index/KNNMethod.java b/src/main/java/org/opensearch/knn/index/KNNMethod.java
@@ -29,11 +29,10 @@
  * the KNNMethodContext passed in by the user. It is also used to provide superficial string translations.
  */
 @AllArgsConstructor
+@Getter
 public class KNNMethod {
 
-    @Getter
     private final MethodComponent methodComponent;
-    @Getter
     private final Set<SpaceType> spaces;
 
     /**

diff --git a/src/main/java/org/opensearch/knn/index/KNNMethodContext.java b/src/main/java/org/opensearch/knn/index/KNNMethodContext.java
@@ -41,6 +41,7 @@
  * It will encompass all parameters necessary to build the index.
  */
 @AllArgsConstructor
+@Getter
 public class KNNMethodContext implements ToXContentFragment, Writeable {
 
     private static KNNMethodContext defaultInstance = null;
@@ -56,11 +57,8 @@ public static synchronized KNNMethodContext getDefault() {
         return defaultInstance;
     }
 
-    @Getter
     private final KNNEngine knnEngine;
-    @Getter
     private final SpaceType spaceType;
-    @Getter
     private final MethodComponentContext methodComponent;
 
     /**

diff --git a/src/main/java/org/opensearch/knn/index/MethodComponent.java b/src/main/java/org/opensearch/knn/index/MethodComponent.java
@@ -12,7 +12,6 @@
 package org.opensearch.knn.index;
 
 import lombok.Getter;
-import lombok.Setter;
 import org.opensearch.common.TriFunction;
 import org.opensearch.common.ValidationException;
 import org.opensearch.knn.common.KNNConstants;
@@ -209,7 +208,6 @@ public static class Builder {
 
         private String name;
         private Map<String, Parameter<?>> parameters;
-        @Setter
         private BiFunction<MethodComponent, MethodComponentContext, Map<String, Object>> mapGenerator;
         private TriFunction<MethodComponent, MethodComponentContext, Integer, Long> overheadInKBEstimator;
         private boolean requiresTraining;

diff --git a/src/main/java/org/opensearch/knn/index/codec/KNNCodecFactory.java b/src/main/java/org/opensearch/knn/index/codec/KNNCodecFactory.java
@@ -35,8 +35,8 @@ public Codec createKNNCodec(final KNNCodecVersion knnCodecVersion, final Codec u
 
     private Codec getCodec(final KNNCodecVersion knnCodecVersion, final Codec userCodec) {
         try {
-            CodecBuilder constructor = codecByVersion.getOrDefault(knnCodecVersion, codecByVersion.get(LATEST_KNN_CODEC_VERSION));
-            return constructor.userCodec(userCodec).build();
+            final CodecBuilder codecBuilder = codecByVersion.getOrDefault(knnCodecVersion, codecByVersion.get(LATEST_KNN_CODEC_VERSION));
+            return codecBuilder.userCodec(userCodec).build();
         } catch (Exception ex) {
             throw new RuntimeException("Cannot create instance of KNN codec", ex);
         }