Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nomenclature changes from Whitelist to Allowlist #534

Conversation

naveentatikonda
Copy link
Member

Signed-off-by: Naveen Tatikonda navtat@amazon.com

Description

Nomenclature changes from Whitelist to Allowlist

Issues Resolved

#307

Check List

  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
@naveentatikonda
Copy link
Member Author

These two packages are not supported by opensearch core in version 2.x. So, will implement these changes later when we increment version to 3.0
org.opensearch.painless.spi.Whitelist -> org.opensearch.painless.spi.Allowlist
org.opensearch.painless.spi.WhitelistLoader -> org.opensearch.painless.spi.AllowlistLoader

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2022

Codecov Report

Merging #534 (5929c90) into main (5e5827e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main     #534   +/-   ##
=========================================
  Coverage     84.04%   84.04%           
  Complexity     1019     1019           
=========================================
  Files           146      146           
  Lines          4188     4188           
  Branches        373      373           
=========================================
  Hits           3520     3520           
  Misses          492      492           
  Partials        176      176           
Impacted Files Coverage Δ
...g/opensearch/knn/plugin/script/KNNScoringUtil.java 98.61% <ø> (ø)
...earch/knn/plugin/script/KNNAllowlistExtension.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@navneet1v navneet1v merged commit c7379f8 into opensearch-project:main Sep 6, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 6, 2022
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
(cherry picked from commit c7379f8)
naveentatikonda pushed a commit that referenced this pull request Sep 6, 2022
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
(cherry picked from commit c7379f8)
martin-gaievski pushed a commit that referenced this pull request Sep 28, 2022
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
@heemin32 heemin32 added v2.3.0 'Issues and PRs related to version v2.3.0' and removed 2.3.0 labels Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement v2.3.0 'Issues and PRs related to version v2.3.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants