Fix: encode body before signing to match manticore adapter encoding. #217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manticore adapter encodes the request body before sending in a different way than the ruby code before signing. In the case of a ISO-8859-1 string it may not match the body being signed, causing a 403.
With
I attempted to match encoding in pure ruby, too, but couldn't find the magical combination. It would be nice if Manticore had a way to callback with the entity being sent to avoid encoding twice, too :(
Repro in #207 (comment).
Issues Resolved
Closes #207.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.