Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove comment which is not applicable now #369

Merged
merged 1 commit into from
Jul 18, 2022
Merged

remove comment which is not applicable now #369

merged 1 commit into from
Jul 18, 2022

Conversation

dhrubo-os
Copy link
Collaborator

@dhrubo-os dhrubo-os commented Jul 18, 2022 •
edited
Loading

Signed-off-by: Dhrubo Saha dhrubo@amazon.com

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dhrubo-os
remove comment which is not applicable now
c138988 
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
@dhrubo-os dhrubo-os marked this pull request as ready for review July 18, 2022 23:24
@dhrubo-os dhrubo-os requested a review from a team July 18, 2022 23:24
ylwu-amzn
ylwu-amzn approved these changes Jul 18, 2022
View reviewed changes
Copy link
Collaborator

@ylwu-amzn ylwu-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this.

amitgalitz
amitgalitz approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@amitgalitz amitgalitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ylwu-amzn ylwu-amzn merged commit 46e8237 into opensearch-project:main Jul 18, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 1, 2022
@dhrubo-os @github-actions
remove comment which is not applicable now (#369)
3a977be 
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
(cherry picked from commit 46e8237)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 1, 2022
Merged
jngz-es pushed a commit that referenced this pull request Aug 4, 2022
@opensearch-trigger-bot @dhrubo-os
remove comment which is not applicable now (#369) (#382)
a2ed4e5 
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
(cherry picked from commit 46e8237)

Co-authored-by: dhrubo-os <109556906+dhrubo-os@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ylwu-amzn ylwu-amzn ylwu-amzn approved these changes

@amitgalitz amitgalitz amitgalitz approved these changes

Assignees
No one assigned
Labels
backport 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhrubo-os @ylwu-amzn @amitgalitz @jngz-es