Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance profile API to add model centric result controlled by view parameter #701

Closed
wants to merge 1 commit into from

Conversation

zane-neo
Copy link
Collaborator

@zane-neo zane-neo commented Jan 19, 2023

Signed-off-by: Zan Niu zaniu@amazon.com

Description

This change is to add model centric result for profile API, so that user can fetch either node centric result or model centric result or both.

Issues Resolved

#646

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…amter

Signed-off-by: Zan Niu <zaniu@amazon.com>
@zane-neo zane-neo requested a review from a team January 19, 2023 02:11
@ylwu-amzn
Copy link
Collaborator

[ant:jacocoReport] Rule violated for class org.opensearch.ml.action.profile.MLProfileModelResponse: lines covered ratio is 0.5, but expected minimum is 0.7
> Task :opensearch-ml-plugin:jacocoTestCoverageVerification FAILED

@zane-neo
Copy link
Collaborator Author

Upstream branches are protected and can't push code to this branch, closing this PR and creating a new PR: #714

@zane-neo zane-neo closed this Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants