Add JDK-20 support

[reta]

Description

Add JDK-20 support

Issues Resolved

Part of #891

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[reta]

@dhrubo-os should fix the delombok failures

[b4sjoo]

Nice

[codecov]

Codecov Report

Merging #986 (fa856c3) into main (26c1db0) will decrease coverage by 0.81%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #986      +/-   ##
============================================
- Coverage     84.73%   83.92%   -0.81%     
- Complexity     1630     1691      +61     
============================================
  Files           135      138       +3     
  Lines          6078     6425     +347     
  Branches        596      646      +50     
============================================
+ Hits           5150     5392     +242     
- Misses          669      753      +84     
- Partials        259      280      +21     

Flag	Coverage Δ
ml-commons	83.92% <ø> (-0.81%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 17 files with indirect coverage changes

[reta]

Nice

Let me try to add JDK-20 to the matrix

[dhrubo-os]

@dhrubo-os should fix the delombok failures

Thanks for raising the PR. Could you please raise the PR for 2.x branch first (if possible)? Our most of the updated codes (including tests) are in 2.x branch.

Then we can backport your PR to main [This is what we are doing for this repo usually]

[b4sjoo]

2.x also moved to jdk20? @dhrubo-os

[dhrubo-os]

Oh my bad. Forgot about that. @reta NVM ignore my comment, lol

[dhrubo-os]

Just curious: should we remove this: id "io.freefair.lombok"?

[reta]

Just curious: should we remove this: id "io.freefair.lombok"?

The plugin is still needed, but it allows to override the lombok version (this is taken from the plugin docs)