Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tasks to publish zips for Notifications and Notifications Core plugins #484

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

qreshi
Copy link
Contributor

@qreshi qreshi commented Jul 19, 2022

Signed-off-by: Mohammad Qureshi 47198598+qreshi@users.noreply.github.com

Description

Publish Notifications and Notifications Core zips to maven repo.

Issues Resolved

#474

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ugins

Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
@qreshi qreshi requested a review from a team July 19, 2022 18:21
@qreshi
Copy link
Contributor Author

qreshi commented Jul 19, 2022

I tested locally and running ./gradlew publishPluginZipPublicationToZipStagingRepository at the top-level project will produce the plugin zip contents for both plugins in the local-staging-repo directory.

Since we have two backend plugins here, we'll need to make the following changes to the scripts in https://github.com/opensearch-project/opensearch-build:

For notifications-core build script:

./gradlew publishPluginZipPublicationToZipStagingRepository -Dopensearch.version=$VERSION -Dbuild.snapshot=$SNAPSHOT -Dbuild.version_qualifier=$QUALIFIER
mkdir -p $OUTPUT/maven/org/opensearch/plugin
cp -r ./build/local-staging-repo/org/opensearch/plugin/opensearch-notifications-core $OUTPUT/maven/org/opensearch/plugin/

For notifications build script:

./gradlew publishPluginZipPublicationToZipStagingRepository -Dopensearch.version=$VERSION -Dbuild.snapshot=$SNAPSHOT -Dbuild.version_qualifier=$QUALIFIER
mkdir -p $OUTPUT/maven/org/opensearch/plugin
cp -r ./build/local-staging-repo/org/opensearch/plugin/notifications $OUTPUT/maven/org/opensearch/plugin/

@peterzhuamazon @prudhvigodithi Can you advise that the changes above to the build scripts are in fact what you expect?

@qreshi qreshi merged commit dae0899 into opensearch-project:main Jul 20, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 20, 2022
…ugins (#484)

Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
(cherry picked from commit dae0899)
@prudhvigodithi
Copy link
Contributor

Hey @qreshi thanks for the PR, please make sure you add publishPluginZipPublicationToZipStagingRepository to the build scripts for the zip to be shipped to maven.
Thank you

qreshi added a commit that referenced this pull request Jul 20, 2022
…ugins (#484) (#485)

Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
(cherry picked from commit dae0899)

Co-authored-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants