Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bwc update #604

Merged
merged 6 commits into from
Mar 28, 2022
Merged

Bwc update #604

merged 6 commits into from
Mar 28, 2022

Conversation

kavithacm
Copy link
Collaborator

@kavithacm kavithacm commented Mar 24, 2022

Description

Add bwc test cases for Event Analytics and Custom Panels

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
@kavithacm kavithacm requested a review from a team as a code owner March 24, 2022 00:09
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2022

Codecov Report

Merging #604 (0d3a360) into main (af54d6a) will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #604      +/-   ##
============================================
+ Coverage     53.32%   53.37%   +0.04%     
  Complexity      271      271              
============================================
  Files           238      239       +1     
  Lines          7748     7736      -12     
  Branches       1581     1566      -15     
============================================
- Hits           4132     4129       -3     
+ Misses         3421     3414       -7     
+ Partials        195      193       -2     
Flag Coverage Δ
dashboards-observability 46.14% <ø> (+0.04%) ⬆️
opensearch-observability 72.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ace_analytics/components/traces/traces_content.tsx 70.00% <0.00%> (ø)
...trace_analytics/components/traces/traces_table.tsx 69.56% <0.00%> (+6.29%) ⬆️
...nents/trace_analytics/components/traces/traces.tsx 100.00% <0.00%> (+35.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af54d6a...0d3a360. Read the comment docs.

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
@kavithacm kavithacm requested review from joshuali925, mengweieric and a team and removed request for a team March 24, 2022 01:27
Copy link
Contributor

@eugenesk24 eugenesk24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☘️ Great!

@kavithacm kavithacm merged commit d3eb604 into opensearch-project:main Mar 28, 2022
@kavithacm kavithacm deleted the bwc-update branch March 28, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants