Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit visualization time change #617

Merged

Conversation

eugenesk24
Copy link
Contributor

Description

  • If visualization is saved with timeRange A, then even if application is at timeRange B, when you edit visualization it shows timeRange A

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2022

Codecov Report

Merging #617 (db61e34) into main (84e56a2) will increase coverage by 22.05%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #617       +/-   ##
=============================================
+ Coverage     54.54%   76.60%   +22.05%     
  Complexity      283      283               
=============================================
  Files           239       38      -201     
  Lines          7795     2154     -5641     
  Branches       1605      228     -1377     
=============================================
- Hits           4252     1650     -2602     
+ Misses         3371      363     -3008     
+ Partials        172      141       -31     
Flag Coverage Δ
dashboards-observability ?
opensearch-observability 76.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lytics/components/config_components/log_config.tsx
...y/public/components/common/search/autocomplete.tsx
...ability/public/components/common/search/search.tsx
...lic/components/custom_panels/custom_panel_view.tsx
...tom_panels/panel_modules/panel_grid/panel_grid.tsx
...isualization_container/visualization_container.tsx
.../config_panel/config_editor/default_vis_editor.tsx
...ards-observability/public/services/requests/ppl.ts
...mponents/common/helpers/ppl_docs/commands/dedup.ts
...race_analytics/components/common/plots/box_plt.tsx
... and 191 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84e56a2...db61e34. Read the comment docs.

…ange

Signed-off-by: Eugene Lee <eugenesk@amazon.com>
@eugenesk24 eugenesk24 marked this pull request as ready for review March 30, 2022 21:45
@eugenesk24 eugenesk24 requested a review from a team as a code owner March 30, 2022 21:45
@eugenesk24 eugenesk24 merged commit 2c3614c into opensearch-project:main Mar 30, 2022
@eugenesk24 eugenesk24 deleted the edit-visualization-time-change branch March 30, 2022 23:34
eugenesk24 added a commit to eugenesk24/trace-analytics that referenced this pull request Jun 6, 2022
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants