Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Retrospective] Release Version 2.2.0 #2451

Closed
peterzhuamazon opened this issue Aug 11, 2022 · 9 comments
Closed

[Retrospective] Release Version 2.2.0 #2451

peterzhuamazon opened this issue Aug 11, 2022 · 9 comments
Assignees
Labels
release v2.2.0 Release 2.2.0

Comments

@peterzhuamazon
Copy link
Member

#2271

How to use this issue?
Please add comments to this issue, they can be small or large in scope. Honest feedback is important to improve our processes, suggestions are also welcomed but not required.

What will happen to this issue post release?
There will be a discussion(s) about how the release went and how the next release can be improved. Then this ticket will be updated with the notes of that discussion along side action items.

@ohltyler
Copy link
Member

Last-minute changes that were merged in core OpenSearch (1-2 days before code cutoff for plugins) caused unforeseen failures in both source code and test cases for plugins (example, example), where not all issues were able to be resolved by the code cutoff. Some were merged after the initial test builds were ready. This made it very difficult to plan for, and potentially could have delayed the release. I recommend core has a cutoff sooner than the plugins to prevent this, and give plugins some more buffer time to better handle situations like this.

Additionally, dependent plugins + core (ref, ref) were not version bumped right after the latest release, and so our AD plugin couldn't test 2.2 compatibility until a few days before the code cutoff. I know this is the goal of infra team already, but it seems to not be enforced. But I believe the auto-version-increment campaigns should improve this for future releases.

@TheMeier
Copy link

The build-tools where not published with the release. See Aiven-Open/prometheus-exporter-plugin-for-opensearch#87

@lukas-vlcek
Copy link

lukas-vlcek commented Aug 12, 2022

I am not able to find any org.opensearch artifacts with 2.2.0 version in public mvn repositories (not just the build-tools as @TheMeier pointed out). Is there any ticket tracking this issue?

This issue has been also reported here.

@kolchfa-aws
Copy link

Specifically regarding release notes: thank you for providing them early to the doc team! In the future, if the developers adhere to the PR naming guidelines, all of the bullet points in the release notes will have consistent verb forms and capitalization. This will avoid bullet points starting with different forms of the same verb like "Add", "adds", "Adding" and "added".

@bbarani
Copy link
Member

bbarani commented Aug 12, 2022

I am not able to find any org.opensearch artifacts with 2.2.0 version in public mvn repositories (not just the build-tools as @TheMeier pointed out). Is there any ticket tracking this issue?

This issue has been also reported here.

Hi @lukas-vlcek We have opened an issue with Sonatype to resolve this issue. We will keep this thread updated with the current status

@bbarani
Copy link
Member

bbarani commented Aug 12, 2022

Some code changes were merged in to 2.2.0 branch after RC build was finalized assuming it will be auto picked up to generate new RC build. We identified this change at the last minute and need a mechanism to prevent this from happening in future.

@bbarani
Copy link
Member

bbarani commented Aug 22, 2022

@ohltyler We dont have plans to freeze core sooner than the cut-off time rather we would like to start the continuous integration process before the code-cutoff date to surface the issues mentioned here sooner. Would it help if we add an additional phase (CI on-boarding) to the release checklist prior to code cut-off? Every plugin team should have version specific branch created and on-boarded on to the manifest by then. CC: @CEHENKLE @dblock

@dblock
Copy link
Member

dblock commented Aug 22, 2022

The existing checklist already has an entry that says "increment the version to next developer iteration", which automatically means that CI should be building on that next version.

@peterzhuamazon
Copy link
Member Author

Thanks everyone for the feedback this retro is closed for now.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release v2.2.0 Release 2.2.0
Projects
None yet
Development

No branches or pull requests

7 participants